Re: [PATCH] Fix crash in int8_avg_combine().

2017-11-27 Thread Hadi Moshayedi
On Sat, Nov 25, 2017 at 10:47 PM, Andres Freund wrote: > diff --git a/src/include/utils/memutils.h b/src/include/utils/memutils.h > > index 869c59dc85..2dc59e89cd 100644 > > --- a/src/include/utils/memutils.h > > +++ b/src/include/utils/memutils.h > > @@ -189,7 +189,7 @@ extern MemoryContext Slab

Re: [PATCH] Fix crash in int8_avg_combine().

2017-11-27 Thread Hadi Moshayedi
On Sat, Nov 25, 2017 at 10:55 PM, Tom Lane wrote: > I believe we already dealt with this: > > Author: Tom Lane > Branch: REL_10_STABLE [619a8c47d] 2017-11-14 17:49:49 -0500 > Branch: REL9_6_STABLE [4a15f87d2] 2017-11-14 17:49:49 -0500 > Branch: REL9_5_STABLE [d4e38489f] 2017-11-14 17:49:49 -0500

Re: [PATCH] Fix crash in int8_avg_combine().

2017-11-26 Thread Andres Freund
Hi Hadi, On 2017-11-25 22:43:49 -0500, Hadi Moshayedi wrote: > While doing some tests on REL_10_STABLE, I was getting run-time exceptions > at int8_avg_combine() at the following line: > > state1->sumX = state2->sumX; > > After some debugging, I noticed that palloc()’s alignment is 8-bytes, whi

Re: [PATCH] Fix crash in int8_avg_combine().

2017-11-25 Thread Tom Lane
Hadi Moshayedi writes: > While doing some tests on REL_10_STABLE, I was getting run-time exceptions > at int8_avg_combine() at the following line: > state1->sumX = state2->sumX; > After some debugging, I noticed that palloc()’s alignment is 8-bytes, while > this statement (which moves a __int128 f

[PATCH] Fix crash in int8_avg_combine().

2017-11-25 Thread Hadi Moshayedi
While doing some tests on REL_10_STABLE, I was getting run-time exceptions at int8_avg_combine() at the following line: state1->sumX = state2->sumX; After some debugging, I noticed that palloc()’s alignment is 8-bytes, while this statement (which moves a __int128 from one memory location to anoth