Re: [PATCH] FIx resource leaks (pg_resetwal.c)

2020-04-23 Thread Ranier Vilela
Em qui., 23 de abr. de 2020 às 16:43, Robert Haas escreveu: > On Thu, Apr 23, 2020 at 2:41 PM Ranier Vilela wrote: > > I do not agree in any way. At the very least what I am reporting is > suspect. And if I already propose a solution even if it is not the best, it > is much better than being sil

Re: [PATCH] FIx resource leaks (pg_resetwal.c)

2020-04-23 Thread Ranier Vilela
Em qui., 23 de abr. de 2020 às 16:27, Peter Geoghegan escreveu: > On Thu, Apr 23, 2020 at 11:41 AM Ranier Vilela > wrote: > > And if I already propose a solution even if it is not the best, it is > much better than being silent and missing the opportunity to fix a bug. > > The problem with that

Re: [PATCH] FIx resource leaks (pg_resetwal.c)

2020-04-23 Thread Robert Haas
On Thu, Apr 23, 2020 at 2:41 PM Ranier Vilela wrote: > I do not agree in any way. At the very least what I am reporting is suspect. > And if I already propose a solution even if it is not the best, it is much > better than being silent and missing the opportunity to fix a bug. > Ridiculous is yo

Re: [PATCH] FIx resource leaks (pg_resetwal.c)

2020-04-23 Thread Peter Geoghegan
On Thu, Apr 23, 2020 at 11:41 AM Ranier Vilela wrote: > And if I already propose a solution even if it is not the best, it is much > better than being silent and missing the opportunity to fix a bug. The problem with that theory is that you're not creating any value over simply running Coverity

Re: [PATCH] FIx resource leaks (pg_resetwal.c)

2020-04-23 Thread Ranier Vilela
Em qui., 23 de abr. de 2020 às 15:27, Andres Freund escreveu: > Hi, > > On 2020-04-23 15:20:59 -0300, Ranier Vilela wrote: > > Per Coverity. > > > > read_controlfile alloc memory with pg_malloc and fail in releasing the > > memory. > > Seriously, this is getting really ridiculous. You're posting

Re: [PATCH] FIx resource leaks (pg_resetwal.c)

2020-04-23 Thread Andres Freund
Hi, On 2020-04-23 15:20:59 -0300, Ranier Vilela wrote: > Per Coverity. > > read_controlfile alloc memory with pg_malloc and fail in releasing the > memory. Seriously, this is getting really ridiculous. You're posting badly vetted, often nearly verbatim, coverity reports. Many of them are obvious

[PATCH] FIx resource leaks (pg_resetwal.c)

2020-04-23 Thread Ranier Vilela
Hi, Per Coverity. read_controlfile alloc memory with pg_malloc and fail in releasing the memory. regards, Ranier Vilela fix_resource_leaks_pg_resetwal.patch Description: Binary data