Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

2025-09-21 Thread David Rowley
On Mon, 22 Sept 2025 at 11:56, Richard Guo wrote: > > On Sun, Sep 21, 2025 at 11:54 PM Steve Lau wrote: > > Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually > > above "join_using_alias", so the code comment could be updated to reflect > > the current field order: > > >

Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

2025-09-21 Thread David Rowley
On Mon, 22 Sept 2025 at 12:49, David Rowley wrote: > > On Mon, 22 Sept 2025 at 11:56, Richard Guo wrote: > > Nice catch. Will push the patch. > > I was just working on a script to find others and it highlighted a > bunch more. Do you still want to do this one, or should I take them > all in one

Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

2025-09-21 Thread Richard Guo
On Sun, Sep 21, 2025 at 11:54 PM Steve Lau wrote: > Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually > above "join_using_alias", so the code comment could be updated to reflect the > current field order: > > > join_using_alias is an alias clause attached directly to JOI

Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

2025-09-21 Thread Chao Li
> On Sep 21, 2025, at 22:48, Steve Lau wrote: > > Hi hackers! > > Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually > above "join_using_alias", so the code comment could be updated to reflect the > current field order: > > > join_using_alias is an alias clause atta

[PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

2025-09-21 Thread Steve Lau
Hi hackers! Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually above "join_using_alias", so the code comment could be updated to reflect the current field order: > join_using_alias is an alias clause attached directly to JOIN/USING. It is > different from the alias fiel