Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions

Hi, On 2023-01-18 10:22:14 -0800, Andres Freund wrote: > On 2023-01-12 08:34:25 +0100, Peter Eisentraut wrote: > > On 07.01.23 08:21, Peter Eisentraut wrote: > > > This patch version looks correct to me.  It is almost the same as the > > > one that Andres had posted in his thread, except that your

Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions

Hi, On 2023-01-12 08:34:25 +0100, Peter Eisentraut wrote: > On 07.01.23 08:21, Peter Eisentraut wrote: > > On 23.11.22 14:57, Aleksander Alekseev wrote: > > > Hi Andres, > > > > > > Thanks for the review! > > > > > > > I don't think it is correct for any of these to add const. The > > > > only r

Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions

On 07.01.23 08:21, Peter Eisentraut wrote: On 23.11.22 14:57, Aleksander Alekseev wrote: Hi Andres, Thanks for the review! I don't think it is correct for any of these to add const. The only reason it works is because of casting etc. Fair enough. PFA the corrected patch v2. This patch ve

Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions

On 23.11.22 14:57, Aleksander Alekseev wrote: Hi Andres, Thanks for the review! I don't think it is correct for any of these to add const. The only reason it works is because of casting etc. Fair enough. PFA the corrected patch v2. This patch version looks correct to me. It is almost the

Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions

Hi Andres, Thanks for the review! > I don't think it is correct for any of these to add const. The only reason it > works is because of casting etc. Fair enough. PFA the corrected patch v2. -- Best regards, Aleksander Alekseev v2-0001-Constify-the-arguments-of-ilist.c-h-functions.patch Descr

Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions

Hi, On 2022-11-07 12:03:23 +0300, Aleksander Alekseev wrote: > During the [1] discussion it was suggested to constify the arguments > of ilist.c/ilist.h functions. Bharath (cc'ed) pointed out that it's > better to start a new thread in order to attract more hackers that may > be interested in this

[PATCH] Const'ify the arguments of ilist.c/ilist.h functions

Hi hackers, During the [1] discussion it was suggested to constify the arguments of ilist.c/ilist.h functions. Bharath (cc'ed) pointed out that it's better to start a new thread in order to attract more hackers that may be interested in this change, so I started one. The patch is attached. Here a