Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers

2021-09-23 Thread Robert Haas
On Thu, Sep 23, 2021 at 5:34 AM Joe Wildish wrote: > Regarding the deparse-and-reparse --- if I understand correctly, the core > problem is that we have no way of going from a node tree to a string, such > that the string is guaranteed to have the same meaning as the node tree? (I > did try jus

Re: Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers

2021-09-23 Thread Tom Lane
Joe Wildish" writes: > On Wed, 22 Sep 2021, at 17:09, Tom Lane wrote: > The main change is a switch to using SPI for expression evaluation. The > plans are also cached along the same lines as the RI trigger plans. >> >> I really dislike this implementation technique. Aside from the likely >> p

Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers

2021-09-23 Thread Joe Wildish
Hi Tom, On Wed, 22 Sep 2021, at 17:09, Tom Lane wrote: > > The main change is a switch to using SPI for expression evaluation. The > > plans are also cached along the same lines as the RI trigger plans. > > I really dislike this implementation technique. Aside from the likely > performance hit

Re: Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers

2021-09-22 Thread Tom Lane
"Joe Wildish" writes: > The main change is a switch to using SPI for expression evaluation. The > plans are also cached along the same lines as the RI trigger plans. I really dislike this implementation technique. Aside from the likely performance hit for existing triggers, I think it opens se

Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers

2021-06-02 Thread Joe Wildish
Y/ALL quantifiers. -Joe From 32cc660e51dc8a157e98cf3f1862fc149b4f68ea Mon Sep 17 00:00:00 2001 From: Joe Wildish Date: Wed, 2 Jun 2021 12:48:34 +0100 Subject: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers Adds support to the trigger system to allow queries in the WHEN c

Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers

2020-12-30 Thread Joe Wildish
main_table (a, b) VALUES (101, 498), (102, 499); server crashed Thanks. It was an incorrect Assert about NULL returns. Fixed. -Joe From 56d010c925db41ffe689044ba215640600976748 Mon Sep 17 00:00:00 2001 From: Joe Wildish Date: Wed, 30 Dec 2020 19:20:10 +0000 Subject: [PATCH] Allow queries

Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers

2020-09-30 Thread Michael Paquier
On Thu, Sep 03, 2020 at 09:22:31PM +0300, Surafel Temesgen wrote: > server crashed That's a problem. As this feedback has not been answered after two weeks, I am marking the patch as returned with feedback. -- Michael signature.asc Description: PGP signature

Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers

2020-09-03 Thread Surafel Temesgen
Hi Joe, This is my review of your patch On Fri, Jul 17, 2020 at 1:22 AM Joe Wildish wrote: > Hi hackers, > > Attached is a patch for supporting queries in the WHEN expression of > statement triggers. - Currently, WHEN expressions cannot contain - subqueries. subqueries in row trigger's is

Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers

2020-07-16 Thread Daniel Gustafsson
> On 17 Jul 2020, at 00:22, Joe Wildish wrote: > Attached is a patch for supporting queries in the WHEN expression of > statement triggers.at? Hi!, Please create an entry for this patch in the 2020-09 commitfest to make sure it's properly tracked: https://commitfest.postgresql.org/29/

[PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers

2020-07-16 Thread Joe Wildish
constructs a Query instead and passes it to the executor. Don't know what people's thoughts are on doing that? -JoeFrom cdc8f5826fc5b0bc576c79c40740ced2400811a4 Mon Sep 17 00:00:00 2001 From: Joe Wildish Date: Thu, 16 Jul 2020 23:04:55 +0100 Subject: [PATCH] Allow queries in WHEN ex