Re: [PATCH] Allow CustomScan nodes to signal projection support

2021-07-06 Thread Tom Lane
Aleksander Alekseev writes: >> I named the flag CUSTOMPATH_SUPPORT_PROJECTION similar to the other >> custom node flags, but this would revert the current logic > This seems to be a typical Kobayashi Maru situation, i.e any choice is > a bad one. I suggest keeping the patch as is and hoping that

Re: [PATCH] Allow CustomScan nodes to signal projection support

2021-05-03 Thread Aleksander Alekseev
Hi Sven, > The attached patch allows CustomScan nodes to signal whether they > support projection. I noticed that you didn't change custom-scan.sgml accordingly. The updated patch is attached. Otherwise, it seems to be fine in terms of compiling, passing tests etc. > I named the flag CUSTOMPATH_

[PATCH] Allow CustomScan nodes to signal projection support

2021-03-26 Thread Sven Klemm
Hi, The attached patch allows CustomScan nodes to signal whether they support projection. Currently all CustomScan nodes are treated as supporting projection. But it would be nice for custom nodes to opt out of this to prevent postgres from modifying the targetlist of the custom node. For feature