On 2021/11/05 21:35, Michael Paquier wrote:
On Fri, Nov 05, 2021 at 10:39:36AM +0100, Daniel Gustafsson wrote:
Is there anything left on this or can we close it in the commitfest?
Oops. I have missed that there was a CF entry for this patch, and
missed that Fujii-san was registered as a co
On Fri, Nov 05, 2021 at 10:39:36AM +0100, Daniel Gustafsson wrote:
> Is there anything left on this or can we close it in the commitfest?
Oops. I have missed that there was a CF entry for this patch, and
missed that Fujii-san was registered as a committer for it. My
apologies!
--
Michael
signa
> On 5 Nov 2021, at 07:30, Michael Paquier wrote:
>
> On Fri, Nov 05, 2021 at 12:31:42PM +0900, Ken Kato wrote:
>> I found unnecessary line deletion in my previous patch, so I made a minor
>> update for that.
>
> I have looked at this version, and this is much simpler than what was
> proposed up
On Fri, Nov 05, 2021 at 12:31:42PM +0900, Ken Kato wrote:
> I found unnecessary line deletion in my previous patch, so I made a minor
> update for that.
I have looked at this version, and this is much simpler than what was
proposed upthread. This looks good, so applied after fixing a couple
of in
Hi,
I found unnecessary line deletion in my previous patch, so I made a
minor update for that.
--
Best wishes,
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index e
+ else if (Matches("COMMENT", "ON", "PROCEDURAL"))
+ COMPLETE_WITH("LANGUAGE");
+ else if (Matches("COMMENT", "ON", "PROCEDURAL", "LANGUAGE"))
+ COMPLETE_WITH_QUERY(Query_for_list_of_languages);
I don't think that there is much point in being this picky either
with
the usage of P
On 2021/10/27 15:54, Shinya Kato wrote:
On 2021-10-27 14:45, Michael Paquier wrote:
On Tue, Oct 26, 2021 at 05:04:24PM +0900, Shinya Kato wrote:
Barring any objection, I will change status to Ready for Committer.
+ else if (Matches("COMMENT", "ON", "PROCEDURAL"))
+ COMPLETE_WITH("L
On Wed, Oct 27, 2021 at 03:54:03PM +0900, Shinya Kato wrote:
> In my opinion, it is written in the documentation, so tab-completion of
> "PROCEDURAL"is good.
It does not mean that we need to add everything either, especially
here as there is a shorter option.
> How about a completion with "LANGUA
On 2021-10-27 14:45, Michael Paquier wrote:
On Tue, Oct 26, 2021 at 05:04:24PM +0900, Shinya Kato wrote:
Barring any objection, I will change status to Ready for Committer.
+ else if (Matches("COMMENT", "ON", "PROCEDURAL"))
+ COMPLETE_WITH("LANGUAGE");
+ else if (Matches("COMMENT", "
On Tue, Oct 26, 2021 at 05:04:24PM +0900, Shinya Kato wrote:
> Barring any objection, I will change status to Ready for Committer.
+ else if (Matches("COMMENT", "ON", "PROCEDURAL"))
+ COMPLETE_WITH("LANGUAGE");
+ else if (Matches("COMMENT", "ON", "PROCEDURAL", "LANGUAGE"))
+ COMPLE
On 2021-10-15 17:49, Ken Kato wrote:
2021-10-15 13:29 に Shinya Kato さんは書きました:
On 2021-10-14 14:30, katouknl wrote:
It is very good, but it seems to me that there are some
tab-completion
missing in COMMENT command.
For example,
- CONSTRAINT ... ON DOMAIN
- OPERATOR CLASS
- OPERATOR FAMILY
- POL
2021-10-15 13:29 に Shinya Kato さんは書きました:
On 2021-10-14 14:30, katouknl wrote:
It is very good, but it seems to me that there are some
tab-completion
missing in COMMENT command.
For example,
- CONSTRAINT ... ON DOMAIN
- OPERATOR CLASS
- OPERATOR FAMILY
- POLICY ... ON
- [PROCEDURAL]
- RULE ... O
On 2021-10-14 14:30, katouknl wrote:
It is very good, but it seems to me that there are some tab-completion
missing in COMMENT command.
For example,
- CONSTRAINT ... ON DOMAIN
- OPERATOR CLASS
- OPERATOR FAMILY
- POLICY ... ON
- [PROCEDURAL]
- RULE ... ON
- TRIGGER ... ON
I think these tab-comle
It is very good, but it seems to me that there are some tab-completion
missing in COMMENT command.
For example,
- CONSTRAINT ... ON DOMAIN
- OPERATOR CLASS
- OPERATOR FAMILY
- POLICY ... ON
- [PROCEDURAL]
- RULE ... ON
- TRIGGER ... ON
I think these tab-comletion also can be improved and it's a g
Hello,
Thanks for the revised patch.
It is very good, but it seems to me that there are some tab-completion
> missing in COMMENT command.
Thanks Shinya, for having a look. I was also about to say that it would be
good
if we take care of tab-completion for other options as well in this patch
itse
On 2021-10-07 17:14, katouknl wrote:
Hi,
Thank you for the review.
I wasn't quite sure where to start counting the characters,
but I used pgindent to properly format it, so hopefully everything is
okay.
Also, I sorted them in alphabetical order just to make it look
prettier.
* The be
Hi,
Thank you for the review.
I wasn't quite sure where to start counting the characters,
but I used pgindent to properly format it, so hopefully everything is
okay.
Also, I sorted them in alphabetical order just to make it look prettier.
* The below change crosses the 80-character li
Hello,
I reviewed your patch. At a first glance, I have the below comments.
1. The below change crosses the 80-character limit in a line. Please
maintain the same.
- "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "ROLE");
+ "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "TRANSFORM FOR"
Hi,
I created a patch for COMMENT tab completion.
It was missing TRANSFORM FOR where it's supposed to be.
Best wishes,
Ken Katodiff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 5cd5838668..d18b26a4a5 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-compl
19 matches
Mail list logo
