Re: [PATCH] Add some documentation on how to call internal functions

Pavel Stehule writes: > pá 18. 10. 2024 v 22:23 odesílatel Tom Lane napsal: >> The problem here is that we failed to pass through the result of >> PG_GET_COLLATION() to text_starts_with. We could do that, certainly, >> for a couple more lines of code. But it feels like this is getting >> into d

Re: [PATCH] Add some documentation on how to call internal functions

pá 18. 10. 2024 v 22:23 odesílatel Tom Lane napsal: > Pavel Stehule writes: > > I'll mark this patch as ready for committer > > I spent a little time looking at this. I agree that it's better to > show conversion of the example function's arguments to and from text* > rather than leaving them a

Re: [PATCH] Add some documentation on how to call internal functions

Pavel Stehule writes: > I'll mark this patch as ready for committer I spent a little time looking at this. I agree that it's better to show conversion of the example function's arguments to and from text* rather than leaving them as Datum. I also do think that we need to incorporate the example

Re: [PATCH] Add some documentation on how to call internal functions

Hi st 9. 10. 2024 v 20:54 odesílatel Florents Tselai napsal: > Here's a v2 > - note on NULL args/returns > - ref PointerGetDatum > - used your example. Started adding some comments but don't think they're > really necessary. The reader gets the point as-is I think. > Now, I don't see any issue

Re: [PATCH] Add some documentation on how to call internal functions

Here's a v2 - note on NULL args/returns - ref PointerGetDatum - used your example. Started adding some comments but don't think they're really necessary. The reader gets the point as-is I think. v2-0001-Add-some-documentation-on-how-to-call-internal-fu.patch Description: Binary data v2-0002-Add

Re: [PATCH] Add some documentation on how to call internal functions

st 9. 10. 2024 v 14:39 odesílatel Florents Tselai napsal: > > > On 9 Oct 2024, at 2:57 PM, Pavel Stehule wrote: > > Hi > > I am checking this patch > > čt 12. 9. 2024 v 11:42 odesílatel Florents Tselai < > florents.tse...@gmail.com> napsal: > >> Hi, >> >> The documentation on extending using C f

Re: [PATCH] Add some documentation on how to call internal functions

> On 9 Oct 2024, at 2:57 PM, Pavel Stehule wrote: > > Hi > > I am checking this patch > > čt 12. 9. 2024 v 11:42 odesílatel Florents Tselai > napsal: >> Hi, >> >> The documentation on extending using C functions, >> leaves a blank on how to call other int

Re: [PATCH] Add some documentation on how to call internal functions

Hi I am checking this patch čt 12. 9. 2024 v 11:42 odesílatel Florents Tselai napsal: > Hi, > > The documentation on extending using C functions, > leaves a blank on how to call other internal Postgres functions. > This can leave first-timers hanging. > > I think it’d be helpful to spend some p

[PATCH] Add some documentation on how to call internal functions

Hi, The documentation on extending using C functions, leaves a blank on how to call other internal Postgres functions.This can leave first-timers hanging.I think it’d be helpful to spend some paragraphs on discussing the DirectFunctionCall API.Here’s an attempt (also a PR[0]).Here’s the relevant HT