Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-03-05 Thread Fujii Masao
On 2025/03/05 9:32, Fujii Masao wrote: On 2025/03/05 7:26, Jacob Champion wrote: On Mon, Mar 3, 2025 at 10:02 PM Fujii Masao wrote: I've pushed the patch. Thanks! Hi all, +tests += { +  'name': 'ecpg', +  'sd': meson.current_source_dir(), +  'bd': meson.current_build_dir(), +  'tap':

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-03-04 Thread Fujii Masao
On 2025/03/05 7:26, Jacob Champion wrote: On Mon, Mar 3, 2025 at 10:02 PM Fujii Masao wrote: I've pushed the patch. Thanks! Hi all, +tests += { + 'name': 'ecpg', + 'sd': meson.current_source_dir(), + 'bd': meson.current_build_dir(), + 'tap': { +'tests': [ + 't/001_ecpg_err_wa

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-03-04 Thread Jacob Champion
On Mon, Mar 3, 2025 at 10:02 PM Fujii Masao wrote: > I've pushed the patch. Thanks! Hi all, > +tests += { > + 'name': 'ecpg', > + 'sd': meson.current_source_dir(), > + 'bd': meson.current_build_dir(), > + 'tap': { > +'tests': [ > + 't/001_ecpg_err_warn_msg.pl', > + 't/002_ecpg_

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-03-03 Thread Fujii Masao
On 2025/03/03 14:09, Ryo Kanbayashi wrote: On Mon, Mar 3, 2025 at 12:23 PM Fujii Masao wrote: On 2025/03/01 19:45, Ryo Kanbayashi wrote: +program_help_ok('ecpg'); +program_version_ok('ecpg'); +program_options_handling_ok('ecpg'); +command_fails(['ecpg'], 'ecpg without arguments fails'); The

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-03-02 Thread Ryo Kanbayashi
>On Mon, Mar 3, 2025 at 12:23 PM Fujii Masao >wrote: > On 2025/03/01 19:45, Ryo Kanbayashi wrote: > >> +program_help_ok('ecpg'); > >> +program_version_ok('ecpg'); > >> +program_options_handling_ok('ecpg'); > >> +command_fails(['ecpg'], 'ecpg without arguments fails'); > >> > >> These checks seem

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-03-02 Thread Fujii Masao
On 2025/03/01 19:45, Ryo Kanbayashi wrote: +program_help_ok('ecpg'); +program_version_ok('ecpg'); +program_options_handling_ok('ecpg'); +command_fails(['ecpg'], 'ecpg without arguments fails'); These checks seem unnecessary in 002 since they're already covered in 001. I reflected above. Th

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-03-01 Thread Ryo Kanbayashi
On Fri, Feb 28, 2025 at 11:27 PM Fujii Masao wrote: > On 2025/02/28 9:24, Ryo Kanbayashi wrote: > > I have rewrote my patch on TAP test sttyle :) > > File for build are also updated. > > Thanks for updating the patch! Thanks for review:) > > +'tests': [ > + 't/001_ecpg_notice.pl', > +

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-02-28 Thread Fujii Masao
On 2025/02/28 9:24, Ryo Kanbayashi wrote: I have rewrote my patch on TAP test sttyle :) File for build are also updated. Thanks for updating the patch! +'tests': [ + 't/001_ecpg_notice.pl', + 't/002_ecpg_notice_informix.pl', Since neither test emits "notice" messages, shouldn

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-02-27 Thread Ryo Kanbayashi
On Tue, Feb 18, 2025 at 12:49 PM Ryo Kanbayashi wrote: > > On Thu, Feb 13, 2025 at 10:49 PM Fujii Masao > wrote: > > > > > > > > On 2025/02/06 8:57, Ryo Kanbayashi wrote: > > > On Wed, Feb 5, 2025 at 9:31 PM Ryo Kanbayashi > > > wrote: > > >> > > >> Hi hackers, > > >> > > >> When I wrote patch

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-02-17 Thread Ryo Kanbayashi
On Thu, Feb 13, 2025 at 10:49 PM Fujii Masao wrote: > > > > On 2025/02/06 8:57, Ryo Kanbayashi wrote: > > On Wed, Feb 5, 2025 at 9:31 PM Ryo Kanbayashi > > wrote: > >> > >> Hi hackers, > >> > >> When I wrote patch of ecpg command notice bug, I recognized needs of > >> regression tests for ecpg c

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-02-13 Thread Fujii Masao
On 2025/02/06 8:57, Ryo Kanbayashi wrote: On Wed, Feb 5, 2025 at 9:31 PM Ryo Kanbayashi wrote: Hi hackers, When I wrote patch of ecpg command notice bug, I recognized needs of regression tests for ecpg command notices and I say that I write the tests. Thanks for working on this! I expl

Fwd: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-02-05 Thread Ryo Kanbayashi
On Wed, Feb 5, 2025 at 9:31 PM Ryo Kanbayashi wrote: > > Hi hackers, > > When I wrote patch of ecpg command notice bug, I recognized needs of > regression tests for ecpg command notices and I say that I write the > tests. > > https://commitfest.postgresql.org/52/5497/ > https://www.postgresql.org/

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

2025-02-05 Thread Ryo Kanbayashi
On Wed, Feb 5, 2025 at 9:31 PM Ryo Kanbayashi wrote: > > Hi hackers, > > When I wrote patch of ecpg command notice bug, I recognized needs of > regression tests for ecpg command notices and I say that I write the > tests. > > https://commitfest.postgresql.org/52/5497/ > https://www.postgresql.org/

[PATCH] Add regression tests of ecpg command notice (error / warning)

2025-02-05 Thread Ryo Kanbayashi
Hi hackers, When I wrote patch of ecpg command notice bug, I recognized needs of regression tests for ecpg command notices and I say that I write the tests. https://commitfest.postgresql.org/52/5497/ https://www.postgresql.org/message-id/0efab1f6-5d8d-451f-a7dc-ef9c73ba9e02%40oss.nttdata.com Thi