Thank you for the corrections. I was busy recently and did not follow
conversations in the mailing list. Sorry about that.
--
With best regards,
Marat Bukharov
вт, 8 окт. 2024 г. в 17:24, Aleksander Alekseev :
>
> Hi,
>
> > I just glanced over this patch. Are you still planning on working on
> >
"Andrey M. Borodin" writes:
> IMO the patch looks RfC.
LGTM too. Pushed.
regards, tom lane
> On 8 Oct 2024, at 19:23, Aleksander Alekseev wrote:
>
> PFA patch v6.
IMO the patch looks RfC.
Best regards, Andrey Borodin.
Hi,
> I just glanced over this patch. Are you still planning on working on
> it? There's been no adjustments made since the last feedback you got
> in early August.
>
> Can you address Andrey's feedback on point #1?
>
> Also, for bytea_larger() and bytea_smaller(), I suggest copying what's
> been
On Thu, 25 Jul 2024 at 02:42, Marat Bukharov wrote:
> V5 patch. I've added more tests with different bytea sizes
I just glanced over this patch. Are you still planning on working on
it? There's been no adjustments made since the last feedback you got
in early August.
Can you address Andrey's fee
"Andrey M. Borodin" writes:
> 0. Please write more descriptive commit message akin to [0]
> 1. Use oids from development range 8000-
Yeah, we don't try anymore to manually select permanent oids [1].
> 2. Replace VARDATA_ANY\memcmp dance with a call to varstrfastcmp_c().
I don't agree with t
> On 24 Jul 2024, at 17:42, Marat Bukharov wrote:
>
> V5 patch. I've added more tests with different bytea sizes
Hi Marat!
This looks like a nice feature to have.
I’ve took a look into the patch and have few suggestions:
0. Please write more descriptive commit message akin to [0]
1. Use oid
Added patch to commitfest https://commitfest.postgresql.org/49/5138/
--
With best regards,
Marat Bukharov
>
> Hi,
>
> > What part of commitfest should I put the current patch to: "SQL
> > Commands", "Miscellaneous" or something else? I can't figure it out.
>
> Personally I qualified a similar pa
V5 patch. I've added more tests with different bytea sizes
--
With best regards,
Marat Bukharov
чт, 4 июл. 2024 г. в 15:29, Aleksander Alekseev :
>
> Hi Marat,
>
> > V4 path with fixed usage PG_GETARG_BYTEA_PP instead of PG_GETARG_TEXT_PP
>
> Thanks for the patch.
>
> Please add it to the neares
Hi,
> What part of commitfest should I put the current patch to: "SQL
> Commands", "Miscellaneous" or something else? I can't figure it out.
Personally I qualified a similar patch [1] as "Server Features",
although I'm not 100% sure if this was the best choice.
[1]: https://commitfest.postgresql
What part of commitfest should I put the current patch to: "SQL
Commands", "Miscellaneous" or something else? I can't figure it out.
--
With best regards,
Marat Bukharov
> Hi Marat,
>
> > V4 path with fixed usage PG_GETARG_BYTEA_PP instead of PG_GETARG_TEXT_PP
>
> Thanks for the patch.
>
> Pleas
Hi Marat,
> V4 path with fixed usage PG_GETARG_BYTEA_PP instead of PG_GETARG_TEXT_PP
Thanks for the patch.
Please add it to the nearest open commitfest [1].
```
+select min(v) from bytea_test_table;
+ min
+--
+ \xaa
+(1 row)
+
+select max(v) from bytea_test_table;
+ max
+--
+ \xff
+(1 r
V4 path with fixed usage PG_GETARG_BYTEA_PP instead of PG_GETARG_TEXT_PP
--
With best regards,
Marat Bukharov
>
> V3 patch with fixed length comparison
>
> >
> > V2 patch with fixed tests
> >
> > >
> > > Hello. BYTEA type has the ability to use comparison operations. But it
> > > is absent of mi
V3 patch with fixed length comparison
--
With best regards,
Marat Bukharov
>
> V2 patch with fixed tests
>
> >
> > Hello. BYTEA type has the ability to use comparison operations. But it
> > is absent of min/max aggregate functions. They are nice to have to
> > provide consistency with the TEXT
V3 patch with fixed length comparison
--
With best regards,
Marat Bukharov
>
> V2 patch with fixed tests
>
> >
> > Hello. BYTEA type has the ability to use comparison operations. But it
> > is absent of min/max aggregate functions. They are nice to have to
> > provide consistency with the TEXT t
V2 patch with fixed tests
--
With best regards,
Marat Bukharov
ср, 3 июл. 2024 г. в 16:03, Marat Buharov :
>
> Hello. BYTEA type has the ability to use comparison operations. But it
> is absent of min/max aggregate functions. They are nice to have to
> provide consistency with the TEXT type.
>
>
Hello. BYTEA type has the ability to use comparison operations. But it
is absent of min/max aggregate functions. They are nice to have to
provide consistency with the TEXT type.
--
With best regards,
Marat Bukharov
From 109b91999b7a8d8c1808658134494b91616c2825 Mon Sep 17 00:00:00 2001
From: Mara
17 matches
Mail list logo
