Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-10-21 Thread Michael Paquier
On Tue, Oct 21, 2025 at 05:16:32PM +0900, Michael Paquier wrote: > Why not if this simple solution works for you, using error_on_null() > as the function name. I'll double-check the whole, probably tomorrow. Applied after a couple of tweaks applied to the code (like added pg_* to the source funct

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-10-21 Thread Michael Paquier
On Sun, Aug 31, 2025 at 04:16:42PM +0200, Vik Fearing wrote: > Thank you.  Updated. This one was marked as committer, so I am looking at it. The original proposal can also be tracked in this message, where you want to have a trick for SQL bodies to be able to detect if exactly one row is returned

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-31 Thread Vik Fearing
On 31/08/2025 16:10, Joel Jacobson wrote: Does it have a commitfest entry where I can make that official? Yes:https://commitfest.postgresql.org/patch/6017/ Thank you.  Updated. -- Vik Fearing

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-31 Thread Joel Jacobson
On Sun, Aug 31, 2025, at 15:54, Vik Fearing wrote: > On 31/08/2025 10:04, Joel Jacobson wrote: >> Thanks for great feedback. New patch attached. > > > This new patch resolves all of my concerns and I think it is ready for > committer. Thanks for reviewing. > Does it have a commitfest entry wher

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-31 Thread Vik Fearing
On 31/08/2025 10:04, Joel Jacobson wrote: Thanks for great feedback. New patch attached. This new patch resolves all of my concerns and I think it is ready for committer.  Does it have a commitfest entry where I can make that official? -- Vik Fearing

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-31 Thread Joel Jacobson
On Sat, Aug 30, 2025, at 18:38, Tom Lane wrote: > Vik Fearing writes: >> On 30/08/2025 13:49, Joel Jacobson wrote: >>> This polymorphic function produces an error if the input value is null, >>> otherwise it returns the input value unchanged. > >> This only checks for the null value. I don't thin

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-30 Thread Tom Lane
Vik Fearing writes: > On 30/08/2025 13:49, Joel Jacobson wrote: >> This polymorphic function produces an error if the input value is null, >> otherwise it returns the input value unchanged. > This only checks for the null value. I don't think we need to change > the function's name, but we do n

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-30 Thread Vik Fearing
On 30/08/2025 13:49, Joel Jacobson wrote: Dear fellow hackers, This polymorphic function produces an error if the input value is null, otherwise it returns the input value unchanged. This only checks for the null value.  I don't think we need to change the function's name, but we do need t

[PATCH] Add error_on_null() to produce an error if the input is null

2025-08-30 Thread Joel Jacobson
Dear fellow hackers, This polymorphic function produces an error if the input value is null, otherwise it returns the input value unchanged. This need for this function originates from the discussion "Assert single row returning SQL-standard functions" [1]. /Joel [1] https://www.postgresql.org