Re: [PATCH] Add error hints for invalid COPY options

2025-11-27 Thread Kirill Reshke
On Wed, 26 Nov 2025 at 11:55, Sugamoto Shinya wrote: > > > > 2025年11月25日(火) 6:50 Nathan Bossart : >> >> On Mon, Nov 24, 2025 at 11:56:34AM -0800, Masahiko Sawada wrote: >> > On Sat, Nov 22, 2025 at 8:33 PM Sugamoto Shinya >> > wrote: >> >> This follows the pattern already used elsewhere in Postg

Re: [PATCH] Add error hints for invalid COPY options

2025-11-27 Thread Kirill Reshke
Hi On Thu, 27 Nov 2025 at 20:38, Sugamoto Shinya wrote: > > > > Regarding the option `convert_selectively`, what do you think about this? > Still it seems to me that this option is accessible from SQL interfaces. But > for now > I just removed the comment changes from my v2 patch and would like t

Re: [PATCH] Add error hints for invalid COPY options

2025-11-27 Thread Sugamoto Shinya
On Wed, Nov 26, 2025 at 5:55 PM Sugamoto Shinya wrote: > > > 2025年11月25日(火) 6:50 Nathan Bossart : > >> On Mon, Nov 24, 2025 at 11:56:34AM -0800, Masahiko Sawada wrote: >> > On Sat, Nov 22, 2025 at 8:33 PM Sugamoto Shinya >> wrote: >> >> This follows the pattern already used elsewhere in PostgreS

Re: [PATCH] Add error hints for invalid COPY options

2025-11-26 Thread Sugamoto Shinya
2025年11月25日(火) 6:50 Nathan Bossart : > On Mon, Nov 24, 2025 at 11:56:34AM -0800, Masahiko Sawada wrote: > > On Sat, Nov 22, 2025 at 8:33 PM Sugamoto Shinya > wrote: > >> This follows the pattern already used elsewhere in PostgreSQL for > providing > >> helpful error hints to users. > > > > Given

Re: [PATCH] Add error hints for invalid COPY options

2025-11-24 Thread Nathan Bossart
On Mon, Nov 24, 2025 at 11:56:34AM -0800, Masahiko Sawada wrote: > On Sat, Nov 22, 2025 at 8:33 PM Sugamoto Shinya wrote: >> This follows the pattern already used elsewhere in PostgreSQL for providing >> helpful error hints to users. > > Given we have 15 COPY options now, it sounds like a reasona

Re: [PATCH] Add error hints for invalid COPY options

2025-11-24 Thread Masahiko Sawada
Hi, On Sat, Nov 22, 2025 at 8:33 PM Sugamoto Shinya wrote: > > Hi, > > This patch improves the user experience when working with COPY commands by > adding helpful error hints for invalid options. > > Currently, when users make typos in COPY option names or values, they receive > a generic error m

[PATCH] Add error hints for invalid COPY options

2025-11-22 Thread Sugamoto Shinya
Hi, This patch improves the user experience when working with COPY commands by adding helpful error hints for invalid options. Currently, when users make typos in COPY option names or values, they receive a generic error message without guidance on what went wrong. This patch adds two types of hi