On Thu, Oct 31, 2024 at 11:10:09AM +0900, Michael Paquier wrote:
> So it looks rather OK seen from here, as you are proposing.
After a second lookup, bumped CATALOG_VERSION_NO, then applied.
--
Michael
signature.asc
Description: PGP signature
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: tested, failed
Documentation:tested, failed
Content.
The proposed function waited long to be implemented
On Wed, Oct 30, 2024 at 10:11:20PM +0300, Пополитов Владлен wrote:
> Makes me wonder if we should have an utility function which would
> contain common code for array_shuffle() and array_reverse().
> Considering inconveniences such an approach caused in case of common
> code for text and bytea type
On Tuesday, October 22, 2024 16:27 MSK, Aleksander Alekseev
wrote:
Hi everyone,
Thanks for the feedback!
> > But it returns the input array as is. I think it should at least make
> > a new copy of input array.
>
> I don't think that's really necessary. We have other functions that
> will
Hi everyone,
Thanks for the feedback!
> > But it returns the input array as is. I think it should at least make
> > a new copy of input array.
>
> I don't think that's really necessary. We have other functions that
> will return an input value unchanged without copying it. A
> longstanding exam
Ashutosh Bapat writes:
> On Mon, Oct 21, 2024 at 2:36 PM Aleksander Alekseev
> wrote:
> + /*
> + * There is no point in reversing empty arrays or arrays with less than
> + * two items.
> + */
> + if (ARR_NDIM(array) < 1 || ARR_DIMS(array)[0] < 2)
> + PG_RETURN_ARRAYTYPE_P(array);
> But it re
On Mon, Oct 21, 2024, at 11:06, Aleksander Alekseev wrote:
> Hi,
>
> Recently I wanted to call array_reverse() and discovered that we still
> don't have it. I'm not the first one who encountered this limitation.
> array_reverse() was requested at least since 2009 [1] and the
> workaround on Postgre
On Mon, Oct 21, 2024 at 2:36 PM Aleksander Alekseev
wrote:
>
> Hi,
>
> Recently I wanted to call array_reverse() and discovered that we still
> don't have it. I'm not the first one who encountered this limitation.
> array_reverse() was requested at least since 2009 [1] and the
> workaround on Post
Hi,
Recently I wanted to call array_reverse() and discovered that we still
don't have it. I'm not the first one who encountered this limitation.
array_reverse() was requested at least since 2009 [1] and the
workaround on PostgreSQL Wiki is dated 2010 [2].
The proposed patch adds this function. On
