Re: [PATCH][BUG_FIX] Potential null pointer dereferencing.

2019-11-12 Thread Kyotaro Horiguchi
At Tue, 12 Nov 2019 14:03:53 +, Ranier Vilela wrote in > Hi, > The condition is : > 74. if (TupIsNull(slot)) is true > 85. if (TupIsNull(resultTupleSlot)) is true too. See the definition of TupIsNull. It checks the tupleslot at a valid pointer is EMPTY as well. And node->ps.ps_ResultTupl

RE: [PATCH][BUG_FIX] Potential null pointer dereferencing.

2019-11-12 Thread Ranier Vilela
PATCH][BUG_FIX] Potential null pointer dereferencing. > On 12 Nov 2019, at 14:07, Ranier Vilela wrote: > ExecClearTuple don't check por NULL pointer arg and according > TupIsNull slot can be NULL. I assume you are referring to the TupIsNull(resultTupleSlot) check a few lines down in

Re: [PATCH][BUG_FIX] Potential null pointer dereferencing.

2019-11-12 Thread Daniel Gustafsson
> On 12 Nov 2019, at 14:07, Ranier Vilela wrote: > ExecClearTuple don't check por NULL pointer arg and according > TupIsNull slot can be NULL. I assume you are referring to the TupIsNull(resultTupleSlot) check a few lines down in the same loop? If resultTupleSlot was indeed NULL and not empty,

[PATCH][BUG_FIX] Potential null pointer dereferencing.

2019-11-12 Thread Ranier Vilela
Hi, ExecClearTuple don't check por NULL pointer arg and according TupIsNull slot can be NULL. Can anyone check this buf fix? --- \dll\postgresql-12.0\a\backend\executor\nodeUnique.cMon Sep 30 17:06:55 2019 +++ nodeUnique.cTue Nov 12 09:54:34 2019 @@ -74,7 +74,8 @@