On 2019-Nov-15, Ranier Vilela wrote:
> Hi,
> Last time, I promise.
>
> It's probably not happening, but it can happen, I think.
This patch assumes that anything can happen after elog(ERROR). That's
wrong -- under ERROR or higher, elog() (as well as ereport) never
returns to the caller. If this
Hi,
Thank you for the explanation.
Best regards.
Ranier Vilela
De: Daniel Gustafsson
Enviado: sexta-feira, 15 de novembro de 2019 11:58
Para: Ranier Vilela
Cc: pgsql-hackers@lists.postgresql.org
Assunto: Re: [PATCH][BUG FIX] Unsafe access pointers.
>
> On 15 Nov 2019, at 12:25, Ranier Vilela wrote:
> It's probably not happening, but it can happen, I think.
I don't think it can, given how elog() works.
> - if (!HeapTupleIsValid(classtup))
> + if (!HeapTupleIsValid(classtup)) {
> elog(ERROR, "cache lookup failed for oper
Hi,
Last time, I promise.
It's probably not happening, but it can happen, I think.
Best regards.
Ranier Vilela
--- \dll\postgresql-12.0\a\backend\access\brin\brin_validate.c Mon Sep 30
17:06:55 2019
+++ brin_validate.c Fri Nov 15 08:14:58 2019
@@ -57,8 +57,10 @@
/* Fetch opclass