Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-11-13 Thread Masahiko Sawada
On Tue, Nov 14, 2017 at 6:50 AM, Tom Lane wrote: > Fabien COELHO writes: Note that if "c" is freed by "d" (drop), then it may be worth considering that "t" (table) could be replaced by "c" (create). > >>> I thought about that, but the argument that 'c' might mean different >>> sorts of

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-11-13 Thread Tom Lane
Fabien COELHO writes: >>> Note that if "c" is freed by "d" (drop), then it may be worth considering >>> that "t" (table) could be replaced by "c" (create). >> I thought about that, but the argument that 'c' might mean different >> sorts of create steps (e.g. create index) seemed reasonable. I th

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-11-13 Thread Fabien COELHO
Note that if "c" is freed by "d" (drop), then it may be worth considering that "t" (table) could be replaced by "c" (create). I thought about that, but the argument that 'c' might mean different sorts of create steps (e.g. create index) seemed reasonable. I think we're best off leaving it as

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-11-13 Thread Tom Lane
Fabien COELHO writes: >> Masahiko Sawada writes: >>> [ pgbench_custom_initialization_v16.patch ] >> I'm starting to review this patch, and I wonder how it is that you >> ended up with "c" as the command letter for dropping existing tables. >> Seems like "d" for DROP would be much less confusing.

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-11-13 Thread Fabien COELHO
Hello Tom, Masahiko Sawada writes: [ pgbench_custom_initialization_v16.patch ] I'm starting to review this patch, and I wonder how it is that you ended up with "c" as the command letter for dropping existing tables. Seems like "d" for DROP would be much less confusing. I see that at one po

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-11-13 Thread Tom Lane
Masahiko Sawada writes: > [ pgbench_custom_initialization_v16.patch ] I'm starting to review this patch, and I wonder how it is that you ended up with "c" as the command letter for dropping existing tables. Seems like "d" for DROP would be much less confusing. I see that at one point "d" meant t