Re: [HACKERS] Supporting huge pages on Windows

2018-01-22 Thread Andrew Dunstan
On 01/22/2018 04:16 AM, Magnus Hagander wrote: > > > > > I'll be quite happy to retire the XP machine running brolga, currawong > and frogmouth, if that's the consensus. XP is now long out of support. > OTOH I have personal experience of it running in many potentially > critical s

Re: [HACKERS] Supporting huge pages on Windows

2018-01-22 Thread Magnus Hagander
On Mon, Jan 22, 2018 at 4:24 AM, Thomas Munro wrote: > On Mon, Jan 22, 2018 at 3:45 AM, Magnus Hagander > wrote: > > I got myself a working build env now so I can at least verify it builds, > > which it does. > > > > With that, I'm pushing this. Let's see what the buildfarm thinks of it. > And >

Re: [HACKERS] Supporting huge pages on Windows

2018-01-22 Thread Magnus Hagander
On Mon, Jan 22, 2018 at 12:13 AM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 01/21/2018 01:02 PM, Andres Freund wrote: > > Hi, > > > > On 2018-01-21 13:42:13 +0200, Magnus Hagander wrote: > >> To add some more notes on this. Again, the API appears in Vista/2003. > >> Windows

Re: [HACKERS] Supporting huge pages on Windows

2018-01-21 Thread Thomas Munro
On Mon, Jan 22, 2018 at 3:45 AM, Magnus Hagander wrote: > I got myself a working build env now so I can at least verify it builds, > which it does. > > With that, I'm pushing this. Let's see what the buildfarm thinks of it. And > if others end up complaining about the platform drop, but I doubt th

Re: [HACKERS] Supporting huge pages on Windows

2018-01-21 Thread Andrew Dunstan
On 01/21/2018 01:02 PM, Andres Freund wrote: > Hi, > > On 2018-01-21 13:42:13 +0200, Magnus Hagander wrote: >> To add some more notes on this. Again, the API appears in Vista/2003. >> Windows Vista went EOL (out of extended support even) in April 2017, >> Windows 2003 did so in July 2015. Those a

Re: [HACKERS] Supporting huge pages on Windows

2018-01-21 Thread Andres Freund
Hi, On 2018-01-21 13:42:13 +0200, Magnus Hagander wrote: > To add some more notes on this. Again, the API appears in Vista/2003. > Windows Vista went EOL (out of extended support even) in April 2017, > Windows 2003 did so in July 2015. Those are the versions that it's *in* -- > obviously the versi

Re: [HACKERS] Supporting huge pages on Windows

2018-01-21 Thread Magnus Hagander
On Sun, Jan 21, 2018 at 6:11 PM, Tom Lane wrote: > Magnus Hagander writes: > > With that, I'm pushing this. Let's see what the buildfarm thinks of it. > And > > if others end up complaining about the platform drop, but I doubt that. > > frogmouth: > > pg_shmem.c: In function 'PGSharedMemoryCreat

Re: [HACKERS] Supporting huge pages on Windows

2018-01-21 Thread Tom Lane
Magnus Hagander writes: > With that, I'm pushing this. Let's see what the buildfarm thinks of it. And > if others end up complaining about the platform drop, but I doubt that. frogmouth: pg_shmem.c: In function 'PGSharedMemoryCreate': pg_shmem.c:205:3: warning: implicit declaration of function

Re: [HACKERS] Supporting huge pages on Windows

2018-01-21 Thread Magnus Hagander
On Sun, Jan 21, 2018 at 2:30 PM, Michael Paquier wrote: > On Sun, Jan 21, 2018 at 01:42:13PM +0200, Magnus Hagander wrote: > > We have traditionally supported older versions of Windows as long as > people > > build from source. But perhaps I'm way overreading that and we should > just > > bite th

Re: [HACKERS] Supporting huge pages on Windows

2018-01-21 Thread Michael Paquier
On Sun, Jan 21, 2018 at 01:42:13PM +0200, Magnus Hagander wrote: > We have traditionally supported older versions of Windows as long as people > build from source. But perhaps I'm way overreading that and we should just > bite the bullet, commit this patch, and declare those platforms as > complete

Re: [HACKERS] Supporting huge pages on Windows

2018-01-21 Thread Magnus Hagander
Sat, Jan 20, 2018 at 2:33 PM, Magnus Hagander wrote: > > > On Fri, Dec 1, 2017 at 5:02 AM, Michael Paquier > wrote: > >> On Fri, Nov 24, 2017 at 9:28 AM, Tsunakawa, Takayuki >> wrote: >> > From: Thomas Munro [mailto:thomas.mu...@enterprisedb.com] >> >> I hope Tsunakawa-san doesn't mind me post

Re: [HACKERS] Supporting huge pages on Windows

2018-01-20 Thread Magnus Hagander
On Fri, Dec 1, 2017 at 5:02 AM, Michael Paquier wrote: > On Fri, Nov 24, 2017 at 9:28 AM, Tsunakawa, Takayuki > wrote: > > From: Thomas Munro [mailto:thomas.mu...@enterprisedb.com] > >> I hope Tsunakawa-san doesn't mind me posting another rebased version of > >> his patch. The last version conf

Re: [HACKERS] Supporting huge pages on Windows

2017-11-30 Thread Michael Paquier
On Fri, Nov 24, 2017 at 9:28 AM, Tsunakawa, Takayuki wrote: > From: Thomas Munro [mailto:thomas.mu...@enterprisedb.com] >> I hope Tsunakawa-san doesn't mind me posting another rebased version of >> his patch. The last version conflicted with the change from SGML to XML >> that just landed in comm

RE: [HACKERS] Supporting huge pages on Windows

2017-11-23 Thread Tsunakawa, Takayuki
From: Thomas Munro [mailto:thomas.mu...@enterprisedb.com] > I hope Tsunakawa-san doesn't mind me posting another rebased version of > his patch. The last version conflicted with the change from SGML to XML > that just landed in commit 3c49c6fa. Thank you very much for keeping it fresh. I hope th

Re: [HACKERS] Supporting huge pages on Windows

2017-11-23 Thread Thomas Munro
On Thu, Sep 14, 2017 at 12:32 AM, Magnus Hagander wrote: > It's my plan to get to this patch during this commitfest. I've been > travelling for open and some 24/7 work so far, but hope to get CFing soon. I hope Tsunakawa-san doesn't mind me posting another rebased version of his patch. The last