Re: [HACKERS] Pluggable storage

2018-06-21 Thread Haribabu Kommi
On Thu, Jun 14, 2018 at 12:25 PM Amit Kapila wrote: > On Thu, Jun 14, 2018 at 1:50 AM, Haribabu Kommi > wrote: > > > > On Fri, Apr 20, 2018 at 4:44 PM Haribabu Kommi > > > wrote: > > > > VACUUM: > > Not much changes are done in this apart moving the Vacuum visibility > > functions as part of th

Re: [HACKERS] Pluggable storage

2018-06-13 Thread Amit Kapila
On Thu, Jun 14, 2018 at 1:50 AM, Haribabu Kommi wrote: > > On Fri, Apr 20, 2018 at 4:44 PM Haribabu Kommi > wrote: > > VACUUM: > Not much changes are done in this apart moving the Vacuum visibility > functions as part of the > storage. But idea for the Vacuum was with each access method can defin

Re: [HACKERS] Pluggable storage

2018-03-29 Thread David Steele
On 3/28/18 8:39 PM, Michael Paquier wrote: > On Wed, Mar 28, 2018 at 12:23:56PM -0400, David Steele wrote: >> I think this entry should be moved the the next CF. I'll do that >> tomorrow unless there are objections. > > Instead of moving things to the next CF by default, perhaps it would > make m

Re: [HACKERS] Pluggable storage

2018-03-28 Thread Michael Paquier
On Wed, Mar 28, 2018 at 12:23:56PM -0400, David Steele wrote: > I think this entry should be moved the the next CF. I'll do that > tomorrow unless there are objections. Instead of moving things to the next CF by default, perhaps it would make more sense to mark things as reviewed with feedback as

Re: [HACKERS] Pluggable storage

2018-03-28 Thread David Steele
On 2/26/18 3:19 AM, Alexander Korotkov wrote: > On Fri, Feb 23, 2018 at 2:20 AM, Robert Haas > wrote: > > On Fri, Feb 16, 2018 at 5:56 AM, Alexander Korotkov > mailto:a.korot...@postgrespro.ru>> wrote: > > BTW, EnterpriseDB announces zheap table access me

Re: [HACKERS] Pluggable storage

2018-02-26 Thread Alexander Korotkov
On Fri, Feb 23, 2018 at 2:20 AM, Robert Haas wrote: > On Fri, Feb 16, 2018 at 5:56 AM, Alexander Korotkov > wrote: > > BTW, EnterpriseDB announces zheap table access method (heap with undo > log) > > [2]. I think this is great, and I'm looking forward for publishing > zheap in > > mailing lists

Re: [HACKERS] Pluggable storage

2018-02-22 Thread Robert Haas
On Fri, Feb 16, 2018 at 5:56 AM, Alexander Korotkov wrote: > BTW, EnterpriseDB announces zheap table access method (heap with undo log) > [2]. I think this is great, and I'm looking forward for publishing zheap in > mailing lists. But I'm concerning about its compatibility with pluggable > table

Re: [HACKERS] Pluggable storage

2018-02-16 Thread Alexander Korotkov
Hi, Haribabu! On Mon, Feb 5, 2018 at 2:22 PM, Haribabu Kommi wrote: > > On Tue, Jan 9, 2018 at 11:42 PM, Haribabu Kommi > wrote: > >> >> Updated patches are attached. >> > > To integrate the columnar store with the pluggable storage API, I found > that > there are couple of other things also th

Re: [HACKERS] Pluggable storage

2018-02-05 Thread Haribabu Kommi
On Tue, Jan 9, 2018 at 11:42 PM, Haribabu Kommi wrote: > > Updated patches are attached. > To integrate the columnar store with the pluggable storage API, I found that there are couple of other things also that needs to be supported. 1. Choosing the right table access method for a particular ta

Re: [HACKERS] Pluggable storage

2018-01-05 Thread Alexander Korotkov
On Fri, Jan 5, 2018 at 7:20 PM, Robert Haas wrote: > I do not like the way that this patch set uses the word "storage". In > current usage, storage is a thing that certain kinds of relations > have. Plain relations (a.k.a. heap tables) have storage, indexes have > storage, materialized views ha

Re: [HACKERS] Pluggable storage

2018-01-05 Thread Robert Haas
I do not like the way that this patch set uses the word "storage". In current usage, storage is a thing that certain kinds of relations have. Plain relations (a.k.a. heap tables) have storage, indexes have storage, materialized views have storage, TOAST tables have storage, and sequences have sto

Re: [HACKERS] Pluggable storage

2018-01-04 Thread Haribabu Kommi
On Fri, Jan 5, 2018 at 9:55 AM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Thu, Jan 4, 2018 at 8:03 AM, Haribabu Kommi > wrote: > >> On Thu, Jan 4, 2018 at 10:00 AM, Alexander Korotkov < >> a.korot...@postgrespro.ru> wrote: >> >>> On Wed, Jan 3, 2018 at 10:08 AM, Haribabu Kommi <

Re: [HACKERS] Pluggable storage

2018-01-04 Thread Alexander Korotkov
On Thu, Jan 4, 2018 at 8:03 AM, Haribabu Kommi wrote: > On Thu, Jan 4, 2018 at 10:00 AM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> On Wed, Jan 3, 2018 at 10:08 AM, Haribabu Kommi > > wrote: >> >>> Apart from rebase, Added storage shared memory API, currently this API >>> is us

Re: [HACKERS] Pluggable storage

2018-01-03 Thread Haribabu Kommi
On Thu, Jan 4, 2018 at 10:00 AM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Wed, Jan 3, 2018 at 10:08 AM, Haribabu Kommi > wrote: > >> >> On Wed, Dec 27, 2017 at 11:33 PM, Alexander Korotkov < >> a.korot...@postgrespro.ru> wrote: >> >>> >>> Also, I appreciate that now tuple_inser

Re: [HACKERS] Pluggable storage

2018-01-03 Thread Alexander Korotkov
On Wed, Jan 3, 2018 at 10:08 AM, Haribabu Kommi wrote: > > On Wed, Dec 27, 2017 at 11:33 PM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> >> Also, I appreciate that now tuple_insert() and tuple_update() methods are >> responsible for inserting index tuples. This unleash pluggabl

Re: [HACKERS] Pluggable storage

2017-12-27 Thread Alexander Korotkov
Hi! On Wed, Dec 27, 2017 at 6:54 AM, Haribabu Kommi wrote: > > On Tue, Dec 12, 2017 at 3:06 PM, Haribabu Kommi > wrote: > >> >> I restructured that patch files to avoid showing unnecessary >> modifications, >> and also it will be easy for adding of new API's based on the all the >> functions >>

Re: [HACKERS] Pluggable storage

2017-11-28 Thread Michael Paquier
On Tue, Nov 14, 2017 at 5:09 PM, Michael Paquier wrote: > On Tue, Nov 7, 2017 at 6:34 PM, Haribabu Kommi > wrote: >> On Tue, Oct 31, 2017 at 8:59 PM, Haribabu Kommi >> wrote: >>> Additional changes that are done in the patches compared to earlier >>> patches apart from rebase. >> >> Rebased pat

Re: [HACKERS] Pluggable storage

2017-11-14 Thread Amit Kapila
On Tue, Nov 14, 2017 at 4:12 PM, Alvaro Herrera wrote: > Hmm. Am I reading it right that this discussion led to moving > essentially all code from tqual.c to heapam? Given the hard time we've > had to get tqual.c right, it seems fundamentally misguided to me to > require that every single storag

Re: [HACKERS] Pluggable storage

2017-11-14 Thread Alvaro Herrera
Hmm. Am I reading it right that this discussion led to moving essentially all code from tqual.c to heapam? Given the hard time we've had to get tqual.c right, it seems fundamentally misguided to me to require that every single storage AM reimplements all the visibility routines. I think that cha

Re: [HACKERS] Pluggable storage

2017-11-14 Thread Michael Paquier
On Tue, Nov 7, 2017 at 6:34 PM, Haribabu Kommi wrote: > On Tue, Oct 31, 2017 at 8:59 PM, Haribabu Kommi > wrote: >> Additional changes that are done in the patches compared to earlier >> patches apart from rebase. > > Rebased patches are attached. This set of patches needs again a... Rebase. --