Re: [HACKERS] Fix warnings and typo in dshash

2018-03-01 Thread Andres Freund
On 2018-02-12 09:23:43 +1300, Thomas Munro wrote: > On Mon, Sep 4, 2017 at 2:18 PM, Amit Kapila wrote: > > On Sun, Sep 3, 2017 at 2:56 PM, Thomas Munro > > wrote: > >> I think it should be (size_t) 1, not UINT64CONST(1). See attached. > > > > Okay, that makes sense. Do you think we should also

Re: [HACKERS] Fix warnings and typo in dshash

2018-02-11 Thread Thomas Munro
On Mon, Sep 4, 2017 at 2:18 PM, Amit Kapila wrote: > On Sun, Sep 3, 2017 at 2:56 PM, Thomas Munro > wrote: >> I think it should be (size_t) 1, not UINT64CONST(1). See attached. > > Okay, that makes sense. Do you think we should also change type > casting in BUCKETS_PER_PARTITION so that we are