Re: [HACKERS] Add Roman numeral conversion to to_number

2017-11-28 Thread Michael Paquier
On Sun, Nov 19, 2017 at 3:32 AM, Tom Lane wrote: > Oliver Ford writes: >> Attached is v2 of src, tests and docs. Doc patch is unchanged from v1. > > I took a quick look at this patch. This got a review, and no replies after 10 days to I am marking it as returned with feedback for now. Oliver, if

Re: [HACKERS] Add Roman numeral conversion to to_number

2017-11-18 Thread Tom Lane
Oliver Ford writes: > Attached is v2 of src, tests and docs. Doc patch is unchanged from v1. I took a quick look at this patch. The roman_to_int function itself seems fairly reasonable, except that I don't like anything about the error reporting. ERRCODE_INVALID_PARAMETER_VALUE doesn't really s

Re: [HACKERS] Add Roman numeral conversion to to_number

2017-11-16 Thread Thomas Munro
On Tue, Sep 19, 2017 at 12:39 AM, Oliver Ford wrote: > Attached is v2 of src, tests and docs. Doc patch is unchanged from v1. Since commit ef73a816, this patch causes make check to fail: too many parallel tests (more than 20) in schedule file "./parallel_schedule" -- Thomas Munro http://www.en