clang static analysis looks good
~/Desktop/checker-279/bin/scan-build make && make install && make
installcheck
scan-build: Using '/Users/wyx/Desktop/checker-279/bin/clang' for static
analysis
/Users/wyx/Desktop/checker-279/bin/../libexec/ccc-analyzer -Wall
-Wmissing-prototypes -Wpointer-arith
commit to change sprintf to snprintf
https://github.com/charles-cui/pg_thrift/commit/1de265a661ab3c61aa593d7e99d3a313024170fc
2018-08-06 8:03 GMT-07:00 Charles Cui :
> got it, will do that asap. Thanks for the comments!
>
> On Mon, Aug 6, 2018, 7:06 AM Aleksander Alekseev
> wrote:
>
>> Hello Cha
got it, will do that asap. Thanks for the comments!
On Mon, Aug 6, 2018, 7:06 AM Aleksander Alekseev wrote:
> Hello Charles,
>
> Personally I believe the project is in a pretty good shape, well done!
> However I would recommend to replace all sprintf calls with it's safer
> version, snprintf. Al
Hello Charles,
Personally I believe the project is in a pretty good shape, well done!
However I would recommend to replace all sprintf calls with it's safer
version, snprintf. Also please consider to run the code through Clang
Static Analyzer and Valgrind one more time just to make sure there are
Hello Charles,
Thanks for keeping us informed. As you probably already discovered the
email I used previously doesn't work any longer. Please add
afis...@gmail.com to CC instead.
I will take a look tomorrow (it's pretty late in my timezone currently).
On Sun, Aug 5, 2018 at 9:05 PM, Charles Cui
Hi mentors and hackers,
The final review is coming. Here is the project summary for the thrift
plugin work for Postgres database. Please let me know if there are anything
missing for the final review.
1. Implement the thrift binary protocol for both simple data structures
(e.g., int, double) an
