Re: [GSoC] github repo and initial work

2018-05-25 Thread Charles Cui
Got it, will go for second method. Will let you guys know the progress. 2018-05-25 4:05 GMT-07:00 Aleksander Alekseev : > Hello Charles, > > I suggest to begin with the second approach and add to_jsonb/from_jsonb > later. Both approaches are fine but it seems to me that most users would > expect

Re: [GSoC] github repo and initial work

2018-05-25 Thread Charles Cui
Thanks for correcting me, will definitely study citext and see how a new type is registered in plugin. 2018-05-24 23:23 GMT-07:00 Aleksandr Parfenov : > On Thu, 24 May 2018 18:25:28 -0700 > Charles Cui wrote: > > The second is to provide thrift type just like json or jsonb. When you > > create

Re: [GSoC] github repo and initial work

2018-05-25 Thread Aleksander Alekseev
Hello Charles, I suggest to begin with the second approach and add to_jsonb/from_jsonb later. Both approaches are fine but it seems to me that most users would expect a separate type thus it's more important. -- Best regards, Aleksander Alekseev signature.asc Description: PGP signature

Re: [GSoC] github repo and initial work

2018-05-24 Thread Aleksandr Parfenov
On Thu, 24 May 2018 18:25:28 -0700 Charles Cui wrote: > The second is to provide thrift type just like json or jsonb. When you > create a table, postgres knows ::thrift keywords. > I think method one should be easier to implement because it only > limits to this plugin. Method two needs modify pos

Re: [GSoC] github repo and initial work

2018-05-24 Thread Charles Cui
Hi guys, As mentioned in the last email that the current interface is based on bytea. To make users easily insert any thrift data structure and show them, we may want to have user friendly (user readable) format for this plugin. I can think about 2 ways to do this. One is to provide to_thrift(j

[GSoC] github repo and initial work

2018-05-21 Thread Charles Cui
Hi mentors and hackers, I have set up a github repo for the pg thrift plugin work, and here is the address (https://github.com/charles-cui/pg_thrift). And I have first version of binary protocol implemented, although it is still a very early stage. The current interface is to return value for s