Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-08-01 Thread Robert Haas
On Mon, Aug 1, 2022 at 1:33 PM Tom Lane wrote: > On the other hand, I'm quite willing to convert WOA state into RWF > state quickly. The author can always resubmit, or resurrect the > old CF entry, once they have something new for people to look at. Right. This is what I'm on about. -- Robert

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-08-01 Thread Tom Lane
Robert Haas writes: > Maybe so, but we routinely have situations where a patch hasn't been > updated in 3-6 months and we tentatively ask the author if it would be > OK to mark it RwF, and they often say something like "please keep it > alive for one more CF to see if I have time to work on it."

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-08-01 Thread Robert Haas
On Mon, Aug 1, 2022 at 12:56 PM Tom Lane wrote: > Yeah, I don't want to introduce make-work into the process; there's > more than enough real work involved. At minimum, a patch that's > shown signs of life since the previous CF should be auto-advanced > to the next one. Maybe so, but we routinel

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-08-01 Thread Tom Lane
Jacob Champion writes: > On 8/1/22 09:33, Robert Haas wrote: >> We really need to move to a system where it's the patch author's job >> to take some action if the patch is alive, rather than having the CM >> (or any other human being) pinging to find out whether it's dead.> Having >> the default

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-08-01 Thread Jacob Champion
On 8/1/22 09:33, Robert Haas wrote: > We really need to move to a system where it's the patch author's job > to take some action if the patch is alive, rather than having the CM > (or any other human being) pinging to find out whether it's dead.> Having the > default action for a patch be to carry

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-08-01 Thread Robert Haas
On Mon, Aug 1, 2022 at 12:30 PM Jacob Champion wrote: > Maybe this is something to look into once we've implemented some more of > the low-hanging usability features that people have asked for. But if we > started doing it now, I'd expect the CFM's job to simply change from > moving patches ahead

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-08-01 Thread Jacob Champion
On 8/1/22 08:51, Justin Pryzby wrote: > @Jacob: Is there any reason why it's necessary to do anything at all ? > Does something bad happen if the patches are left in the current CF ? > Why make not let patch authors (re) submit the patch for review when they're > ready? Someone went to the effort

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-08-01 Thread Justin Pryzby
On Thu, Jul 28, 2022 at 08:58:31AM -0700, Jacob Champion wrote: > On Thu, Jul 28, 2022 at 4:46 AM Andrey Borodin wrote: > > Daniil is working on this, but currently he's on vacation. > > I think we should not mark patch as RwF and move it to next CF instead. > > Is there a downside to marking it

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-07-28 Thread Jacob Champion
On Thu, Jul 28, 2022 at 4:46 AM Andrey Borodin wrote: > Daniil is working on this, but currently he's on vacation. > I think we should not mark patch as RwF and move it to next CF instead. Is there a downside to marking it RwF, from your perspective? As Robert pointed out upthread, it can be swit

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-07-28 Thread Jacob Champion
On Wed, Jul 27, 2022 at 7:09 PM houzj.f...@fujitsu.com wrote: > Sorry, I think we don't enough time to work on this recently. So please mark > it as RWF and > we will get back to this in the future. Done, thanks! --Jacob

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-07-28 Thread Andrey Borodin
> 27 июля 2022 г., в 00:26, Jacob Champion написал(а): > > - libpq compression > https://commitfest.postgresql.org/38/3499/ > > Needs a rebase and response to feedback; mostly quiet since January. Daniil is working on this, but currently he's on vacation. I think we should not mark patch a

RE: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-07-27 Thread houzj.f...@fujitsu.com
On Wednesday, July 27, 2022 3:27 AM Jacob Champion wrote: > > - Parallel INSERT SELECT take 2 > https://commitfest.postgresql.org/38/3143/ > > There was a lot of discussion early on in this patchset's life, and > then it got caught in a rebase loop without review in August 2021. The > t

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-07-27 Thread Robert Haas
On Tue, Jul 26, 2022 at 7:47 PM James Coleman wrote: > These are both mine, and I'd hoped to work on them this CF, but I've > been sufficiently busy that that hasn't happened. > > I'd like to just move these to the next CF. Well, if we mark them returned with feedback now, and you get time to wor

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-07-26 Thread James Coleman
On Tue, Jul 26, 2022 at 3:27 PM Jacob Champion wrote: ... > - Consider parallel for LATERAL subqueries having LIMIT/OFFSET > https://commitfest.postgresql.org/38/2851/ > > Does this have a path forward? It's been Waiting on Author since the > beginning of last CF, with open concerns from Tom

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-07-26 Thread Jacob Champion
On 7/26/22 16:20, Justin Pryzby wrote: > I suggest that, if you send an email when marking as RWF, to mention that the > existing patch record can be re-opened and moved to next CF. > > I'm aware that people may think that this isn't always a good idea, but it's > nice to mention that it's possibl

Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

2022-07-26 Thread Justin Pryzby
On Tue, Jul 26, 2022 at 12:26:59PM -0700, Jacob Champion wrote: > Hello all, > > I'm making my way through some stalled patches in Waiting on Author. If > nothing changes by the end of this CF, I'd recommend marking these > as Returned with Feedback. +1 I suggest that, if you send an email when

[Commitfest 2022-07] Patch Triage: Waiting on Author

2022-07-26 Thread Jacob Champion
Hello all, I'm making my way through some stalled patches in Waiting on Author. If nothing changes by the end of this CF, I'd recommend marking these as Returned with Feedback. Patch authors CC'd. - jsonpath syntax extensions https://commitfest.postgresql.org/38/2482/ As a few people pointe