Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1

2022-07-29 Thread Julien Rouhaud
Hi Jacob, On Fri, Jul 29, 2022 at 10:08:08AM -0700, Jacob Champion wrote: > > On Thu, Jul 28, 2022 at 11:38 PM Julien Rouhaud wrote: > > > - Add extra statistics to explain for Nested Loop > > > https://commitfest.postgresql.org/38/2765/ > > > > > > [...] > > > > As I mentioned in [1], this pa

Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1

2022-07-29 Thread Jacob Champion
Hi Julien, On Thu, Jul 28, 2022 at 11:38 PM Julien Rouhaud wrote: > > - Add extra statistics to explain for Nested Loop > > https://commitfest.postgresql.org/38/2765/ > > > > [...] > > As I mentioned in [1], this patch breaks the current assumption that > INSTRUMENT_ALL will lead to statement-l

Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1

2022-07-29 Thread Jacob Champion
On Thu, Jul 28, 2022 at 2:51 PM Tom Lane wrote: > > - Fix behavior of geo_ops when NaN is involved > > https://commitfest.postgresql.org/38/2710/ > > > Stuck in a half-committed state, which is tricky. Could maybe use a > > reframing or recap (or a new thread?). > > We fixed a couple of easy cas

Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1

2022-07-28 Thread Julien Rouhaud
Hi, On Thu, Jul 28, 2022 at 02:28:23PM -0700, Jacob Champion wrote: > > = Stalled Patches, Need Help = > [...] > - Add extra statistics to explain for Nested Loop > https://commitfest.postgresql.org/38/2765/ > > I think the author is hoping for help with testing and performance > characterizatio

Re: [Commitfest 2022-07] Patch Triage: Needs Review, Part 1

2022-07-28 Thread Tom Lane
Jacob Champion writes: > Next up is the large list of Needs Review. This part 1 should include > entries as old or older than seven commitfests running. I'm just commenting on a couple that I've been involved with. > = Stalled Patches, Recommend Return = > - Fix up partitionwise join on how equ

[Commitfest 2022-07] Patch Triage: Needs Review, Part 1

2022-07-28 Thread Jacob Champion
Hi, Next up is the large list of Needs Review. This part 1 should include entries as old or older than seven commitfests running. My heuristics for classifying these continue to evolve as I go, and there's a lot to read, so please let me know if I've made any mistakes. = Stalled Patches, Recomme