On Thu, Nov 25, 2021 at 10:44:53AM +0530, Dilip Kumar wrote:
> Good catch, your patch looks fine to me and solves the reported problem.
And applied down to 10. A couple of comments in the same area did not
get the call, though.
--
Michael
signature.asc
Description: PGP signature
On Thu, Nov 25, 2021 at 8:21 AM tanghy.f...@fujitsu.com
wrote:
>
> On Wed, Nov 24, 2021 7:29 PM, Michael Paquier wrote:
>
> Thanks for your comment. I agree with you.
> I have fixed it and attached v2 patch.
Good catch, your patch looks fine to me and solves the reported problem.
--
Regards,
On Wed, Nov 24, 2021 7:29 PM, Michael Paquier wrote:
>
> On Wed, Nov 24, 2021 at 07:04:51AM +, tanghy.f...@fujitsu.com wrote:
> > create table tbl (a int not null unique);
> > alter table tbl replica identity using INDEX tbl_a_key;
> > alter table tbl alter column a drop not null;
> > insert
On Wed, Nov 24, 2021 at 07:04:51AM +, tanghy.f...@fujitsu.com wrote:
> create table tbl (a int not null unique);
> alter table tbl replica identity using INDEX tbl_a_key;
> alter table tbl alter column a drop not null;
> insert into tbl values (null);
Oops. Yes, that's obviously not good.
>
Hi,
I think I found a problem related to replica identity. According to PG doc at
[1], replica identity includes only columns marked NOT NULL.
But in fact users can accidentally break this rule as follows:
create table tbl (a int not null unique);
alter table tbl replica identity using INDEX t
