Re: [BUG] segfault during delete

2021-02-28 Thread Amit Langote
On Sun, Feb 28, 2021 at 6:14 AM Álvaro Herrera wrote: > Thanks Amit for working on this fix! It seems correct to me, so I pushed it > with trivial changes. Thanks Bertrand for reporting the problem. Thanks Alvaro. > In addition to backpatching the code fix to pg12, I backpatched the test case

Re: [BUG] segfault during delete

2021-02-27 Thread Álvaro Herrera
Thanks Amit for working on this fix! It seems correct to me, so I pushed it with trivial changes. Thanks Bertrand for reporting the problem. In addition to backpatching the code fix to pg12, I backpatched the test case to pg11. It worked fine for me (with no code changes), but it seems good to

Re: [BUG] segfault during delete

2021-02-24 Thread Amit Langote
On Wed, Feb 24, 2021 at 6:12 PM Drouvot, Bertrand wrote: > On 2/24/21 9:12 AM, Amit Langote wrote: > > I've attached a patch with my suggested fixes and also test cases. > > Please take a look. > > I had a look and it looks good to me. Also the new regression tests are > doing it right and are seg

Re: [BUG] segfault during delete

2021-02-24 Thread Amit Langote
Hi Bertrand, On Wed, Feb 24, 2021 at 5:56 AM Drouvot, Bertrand wrote: > Hi hackers, > > Here is a scenario that segfault during delete (with version >= 12): > > create table parent ( > col1 text primary key > ); > > create table child ( > col1 text primary key, > FOREIGN KEY (col1) REFERENCES par