Re: [BUG] orphaned function

2021-04-08 Thread David Steele
On 3/29/21 7:20 AM, Drouvot, Bertrand wrote: This item is classified as a bug-fix in the commitfest, but it doesn't sound like something we can actually back-patch. Since it looks like a new patch is required and this probably should not be classified as a bug fix, marking Returned with Feedb

Re: [BUG] orphaned function

2021-03-27 Thread Alvaro Herrera
On 2021-Feb-02, Drouvot, Bertrand wrote: > On 12/18/20 12:26 AM, Tom Lane wrote: > > But any of these options lead to the same question: why stop there? > > An approach that would actually be defensible, perhaps, is to incorporate > > this functionality into the dependency mechanism: any time we'

Re: [BUG] orphaned function

2021-02-01 Thread Masahiko Sawada
On Mon, Feb 1, 2021 at 11:06 PM Drouvot, Bertrand wrote: > > Hi Sawada, > > On 2/1/21 2:37 PM, Masahiko Sawada wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe

Re: [BUG] orphaned function

2021-02-01 Thread Masahiko Sawada
On Mon, Feb 1, 2021 at 11:26 AM Masahiko Sawada wrote: > > Hi Bertrand, > > On Fri, Dec 18, 2020 at 6:52 PM Gilles Darold wrote: > > > > Le 18/12/2020 à 00:26, Tom Lane a écrit : > > > Gilles Darold writes: > > >> The same problem applies if the returned type or the procedural language > > >> is

Re: [BUG] orphaned function

2021-01-31 Thread Masahiko Sawada
Hi Bertrand, On Fri, Dec 18, 2020 at 6:52 PM Gilles Darold wrote: > > Le 18/12/2020 à 00:26, Tom Lane a écrit : > > Gilles Darold writes: > >> The same problem applies if the returned type or the procedural language > >> is dropped. I have tried to fix that in ProcedureCreate() by using an > >>

Re: [BUG] orphaned function

2020-12-18 Thread Gilles Darold
Le 18/12/2020 à 00:26, Tom Lane a écrit : Gilles Darold writes: The same problem applies if the returned type or the procedural language is dropped. I have tried to fix that in ProcedureCreate() by using an AccessSharedLock for the data types and languages involved in the function declaration.

Re: [BUG] orphaned function

2020-12-17 Thread Tom Lane
Gilles Darold writes: > The same problem applies if the returned type or the procedural language > is dropped. I have tried to fix that in ProcedureCreate() by using an > AccessSharedLock for the data types and languages involved in the > function declaration. With this patch the race condition

Re: [UNVERIFIED SENDER] Re: [BUG] orphaned function

2020-12-17 Thread Gilles Darold
Le 02/12/2020 à 11:46, Drouvot, Bertrand a écrit : I ended up making more changes in QualifiedNameGetCreationNamespace () to mimic the retry() logic that is in RangeVarGetAndCheckCreationNamespace(). The att

Re: [BUG] orphaned function

2020-11-30 Thread Tom Lane
"Drouvot, Bertrand" writes: > here is a scenario that produces an orphaned function (means it does not > belong to any namespace): > [ drop schema before committing function creation ] Hm. Historically we've not been too fussed about preventing such race conditions, and I wonder just how far is