Re: [BUG] Crash on pgbench initialization.

2023-07-25 Thread Anton A. Melnikov
On 25.07.2023 06:24, Andres Freund wrote: Thanks Anton / Victoria for the report and fix. Pushed. Thanks! Have a nice day! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [BUG] Crash on pgbench initialization.

2023-07-24 Thread Andres Freund
Hi, On 2023-07-24 09:42:44 -0700, Andres Freund wrote: > > I don't know this code at all, but I hope that this can be solved with > > just Anton's proposed patch. > > Yes, it's just that off-by-one. I need to check if there's a similar bug for > local / temp table buffers though. Doesn't appear

Re: [BUG] Crash on pgbench initialization.

2023-07-24 Thread Michael Paquier
On Mon, Jul 24, 2023 at 03:54:33PM +0200, Alvaro Herrera wrote: > I see Michael marked it as such in the open items > page, but did not CC Andres, so I'm doing that here now. Indeed, thanks! -- Michael signature.asc Description: PGP signature

Re: [BUG] Crash on pgbench initialization.

2023-07-24 Thread Andres Freund
Hi, On 2023-07-24 15:54:33 +0200, Alvaro Herrera wrote: > On 2023-Jul-24, Michael Paquier wrote: > > > On Sun, Jul 23, 2023 at 11:21:47PM +0300, Anton A. Melnikov wrote: > > > After some research, found this happens when the LimitAdditionalPins() > > > returns exactly zero. > > > In the current

Re: [BUG] Crash on pgbench initialization.

2023-07-24 Thread Alvaro Herrera
On 2023-Jul-24, Michael Paquier wrote: > On Sun, Jul 23, 2023 at 11:21:47PM +0300, Anton A. Melnikov wrote: > > After some research, found this happens when the LimitAdditionalPins() > > returns exactly zero. > > In the current master, this will happen e.g. if shared_buffers = 10MB and > > max_w

Re: [BUG] Crash on pgbench initialization.

2023-07-24 Thread Michael Paquier
On Sun, Jul 23, 2023 at 11:21:47PM +0300, Anton A. Melnikov wrote: > After some research, found this happens when the LimitAdditionalPins() > returns exactly zero. > In the current master, this will happen e.g. if shared_buffers = 10MB and > max_worker_processes = 40. > Then the command "pgbench

[BUG] Crash on pgbench initialization.

2023-07-23 Thread Anton A. Melnikov
Hello! My colleague Victoria Shepard reported that pgbench might crash during initialization with some values of shared_buffers and max_worker_processes in conf. After some research, found this happens when the LimitAdditionalPins() returns exactly zero. In the current master, this will happen