Re: [18] CREATE SUBSCRIPTION ... SERVER

2025-04-08 Thread Jeff Davis
On Wed, 2025-04-02 at 17:58 +0530, Shlok Kyal wrote: > I reviewed the patch and I have a comment: Thank you and vignesh for the feedback. This patch didn't quite make it for v18, but I will address it for the next CF. Regards, Jeff Davis

Re: [18] CREATE SUBSCRIPTION ... SERVER

2025-04-05 Thread Shlok Kyal
On Sat, 1 Mar 2025 at 04:35, Jeff Davis wrote: > > On Mon, 2024-12-16 at 20:05 -0800, Jeff Davis wrote: > > On Wed, 2024-10-30 at 08:08 -0700, Jeff Davis wrote: > > > > Rebased v14. > > The approach has changed multiple times. It starte off with more in- > core code, but in response to review feed

Re: [18] CREATE SUBSCRIPTION ... SERVER

2025-03-24 Thread vignesh C
On Sat, 1 Mar 2025 at 04:35, Jeff Davis wrote: > > On Mon, 2024-12-16 at 20:05 -0800, Jeff Davis wrote: > > On Wed, 2024-10-30 at 08:08 -0700, Jeff Davis wrote: > > > > Rebased v14. > > The approach has changed multiple times. It starte off with more in- > core code, but in response to review feed

Re: [18] CREATE SUBSCRIPTION ... SERVER

2025-03-24 Thread vignesh C
On Sat, 1 Mar 2025 at 04:35, Jeff Davis wrote: > > On Mon, 2024-12-16 at 20:05 -0800, Jeff Davis wrote: > > On Wed, 2024-10-30 at 08:08 -0700, Jeff Davis wrote: > > > > Rebased v14. > > The approach has changed multiple times. It starte off with more in- > core code, but in response to review feed

Re: [18] CREATE SUBSCRIPTION ... SERVER

2025-02-28 Thread Jeff Davis
On Mon, 2024-12-16 at 20:05 -0800, Jeff Davis wrote: > On Wed, 2024-10-30 at 08:08 -0700, Jeff Davis wrote: > Rebased v14. The approach has changed multiple times. It starte off with more in- core code, but in response to review feedback, has become more decoupled from core and more coupled to p