Re: [17+] check after second call to pg_strnxfrm is too strict, relax it

2024-07-31 Thread Jeff Davis
On Tue, 2024-07-30 at 23:01 +0300, Heikki Linnakangas wrote: > +1. A comment in the pg_strnxfrm() function itself would be good too. Committed, thank you. Backported to 16 (original email said 17, but that was a mistake). Regards, Jeff Davis

Re: [17+] check after second call to pg_strnxfrm is too strict, relax it

2024-07-30 Thread Heikki Linnakangas
On 30/07/2024 22:31, Jeff Davis wrote: I noticed this comment in selfuncs.c regarding strxfrm(): /* * Some systems (e.g., glibc) can return a smaller value from the * second call than the first; thus the Assert must be <= not ==. */ Some callers of pg_strnxfrm() are not a

[17+] check after second call to pg_strnxfrm is too strict, relax it

2024-07-30 Thread Jeff Davis
I noticed this comment in selfuncs.c regarding strxfrm(): /* * Some systems (e.g., glibc) can return a smaller value from the * second call than the first; thus the Assert must be <= not ==. */ Some callers of pg