Re: Asynchronous and "direct" IO support for PostgreSQL.

2023-01-17 Thread Wenjing Zeng
AioBufferTag *tag = &io->scb_data.write_smgr.tag; SMgrRelation reln = smgropen(tag->rlocator.locator, tag->rlocator.backend); io->op_data.read.fd = smgrfd(reln, tag->forkNum, tag->blockNum, &off); Assert(off == io->op_data.read.offset); } seems should to be: io->op_data.write.fd = smgrfd(reln, tag->forkNum, tag->blockNum, &off); Assert(off == io->op_data.write.offset); Best regards, Wenjing > > Greetings, > > Andres Freund >

Re: [Commitfest 2022-07] Begins Now

2022-07-15 Thread Wenjing Zeng
Hi Jacob Abort Global temporary table https://commitfest.postgresql.org/36/2349/# <https://commitfest.postgresql.org/36/2349/#> Please move the Global Temporary table to check next month, that is at 202208. I need more time to process the existing issue. Thanks Wenjing > 2022年7月9日 07

Re: [Proposal] Global temporary tables

2022-03-01 Thread Wenjing Zeng
t; > I think it's not a great idea to solve multiple complicated problems at > once... I'm trying to break down the entire implementation into multiple sub-patches. Regards, Wenjing. > > Greetings, > > Andres Freund > >

Re: [Proposal] Global temporary tables

2022-02-28 Thread Wenjing Zeng
It is smart to use unlogged table as a template and then use LTT to read and write data. For this implementation, I want to point out two things: 1 For the first insert of GTT in each session, create table or create index is implicitly executed. 2 The catalog bloat caused by LTT still exist. Regards, Wenjing. > <0002-f-0002-gtt-v64-doc.txt><0004-f-0003-gtt-v64-implementation.txt><0006-f-0004-gtt-v64-regress.txt>

Re: [Proposal] Global temporary tables

2022-02-28 Thread Wenjing Zeng
dme does a bit of that, > but not particularly well. Thank you for your review of the design and code. I'm always trying to improve it. If you are confused or need clarification on something, please point it out. > > > On 2022-02-25 14:26:47 +0800, Wenjing Zeng wrote: >>

Re: [PATCH] Implement INSERT SET syntax

2022-01-21 Thread wenjing zeng
Since this feature adds INSERT OVERRIDING SET syntax, it is recommended to add some related testcases. Regards Wenjing > 2021年9月22日 07:38,Rachel Heaton 写道: > >> On 4/23/20 8:04 PM, Gareth Palmer wrote: >>> >>> Thank you for the review, attached is v7 of th

Re: CREATE TABLE ( .. STORAGE ..)

2022-01-20 Thread wenjing zeng
member storage_name, did you miss the function _copyColumnDef() _equalColumnDef()? Regards Wenjing > 2021年12月27日 15:51,Teodor Sigaev 写道: > > Hi! > > Working on pluggable toaster (mostly, for JSONB improvements, see links > below) I had found that STORAGE attribute on column is

Re: 回复:Re: Re: 回复:Re: Is it worth pushing conditions to sublink/subplan?

2022-01-05 Thread wenjing
I corrected it according to your suggestion. thanks Wenjing. Zhihong Yu 于2021年12月25日周六 02:26写道: > > > On Thu, Dec 23, 2021 at 3:52 AM 曾文旌(义从) > wrote: > >> >> Fixed a bug found during testing. >> >> >> Wenjing >> >> >>>&

Re: why does reindex invalidate relcache without modifying system tables

2022-01-03 Thread wenjing zeng
> 2021年12月27日 23:54,Tom Lane 写道: > > wenjing zeng writes: >> I found that in the index_update_stats function, i.e. the CREATE >> INDEX/REINDEX/Truncate INDEX process, >> relchche is invalidated whether the index information is updated. I want to >> know

why does reindex invalidate relcache without modifying system tables

2021-12-27 Thread wenjing zeng
don't do this. 2 Local Temp table with ON COMMIT DELETE ROWS builds index for each transaction commit. This causes relcache of the temp table to be rebuilt over and over again. Looking forward to your reply. Thanks Wenjing

Re: [Proposal] Global temporary tables

2021-10-14 Thread wenjing zeng
analyzing them as soon as possible. Wenjing > > On Sat, Oct 9, 2021 at 2:41 PM wenjing <mailto:wjzeng2...@gmail.com>> wrote: > > Thank you for pointing it out. > This is a bug that occurs during transaction rollback and process exit, I > fixed it, please confirm it. > > Wenjing

Re: [Proposal] Global temporary tables

2021-09-23 Thread wenjing
Andrew Dunstan 于2021年3月28日周日 下午9:07写道: > > On 3/17/21 7:59 AM, wenjing wrote: > > ok > > > > The cause of the problem is that the name of the dependent function > > (readNextTransactionID) has changed. I fixed it. > > > > This patch(V43) is base o

Re: [Proposal] Global temporary tables

2021-09-22 Thread wenjing
2021年7月14日 10:56,Ming Li 写道: Hi Wenjing, Some suggestions may help: 1) It seems that no test case covers the below scenario: 2 sessions attach the same gtt, and insert/update/select concurrently. It is better to use the test framework in src/test/isolation like the code changes in https

Re: Is it worth pushing conditions to sublink/subplan?

2021-08-16 Thread Wenjing
> 2021年8月16日 17:15,Wenjing 写道: > > Hi Hackers, > > Recently, a issue has been bothering me, This is about conditional push-down > in SQL. > I use cases from regression testing as an example. > I found that the conditions (B =1) can be pushed down into the subquery,

Is it worth pushing conditions to sublink/subplan?

2021-08-16 Thread Wenjing
/subplan clause contains a partition table, it can be useful to get the conditions for pruning. So, is it worth pushing conditions to sublink/subplan? Anybody have any ideas? regards, Wenjing example: create table p (a int, b int, c int) partition by list (a); create table p1 partition of p for

Re: [Proposal] Global temporary tables

2021-07-29 Thread wenjing zeng
> 2021年7月28日 23:09,Tony Zhu 写道: > > Hi Wenjing > > would you please rebase the code? Thank you for your attention. According to the test, the latest pgmaster code can merge the latest patch and pass the test. https://www.travis-ci.com/github/wjzeng/postgres/builds <https:/

Re: [Proposal] Global temporary tables

2020-07-22 Thread wenjing zeng
> 2020年7月14日 下午10:28,Pavel Stehule 写道: > > > > pá 10. 7. 2020 v 11:04 odesílatel wenjing zeng <mailto:wjzeng2...@gmail.com>> napsal: > HI all > > I started using my personal email to respond to community issue. > > > >> 2020年7月7日 下午6:05

Re: [Proposal] Global temporary tables

2020-07-13 Thread wenjing zeng
> 2020年7月10日 下午5:03,wenjing zeng 写道: > > HI all > > I started using my personal email to respond to community issue. > > > >> 2020年7月7日 下午6:05,Pavel Stehule > <mailto:pavel.steh...@gmail.com>> 写道: >> >> Hi >> >> GTT

Re: [Proposal] Global temporary tables

2020-07-10 Thread wenjing zeng
ble lock level to RowExclusiveLock, So We can truncate data in the same GTT between different sessions at the same time. What do you think about table locks on GTT? Wenjing > > Now, table locks are implemented on a global level. So exclusive lock on GTT > in one session block inser