Re: Detoasting optionally to make Explain-Analyze less misleading

2024-04-10 Thread stepan rutz
First of all thanks for bringing this Feature to PostgreSQL. From a regular-user perspective (not everyone is a Pro) it is very misleading that ANALYZE doesn't do what it suggests it does. To run the query into some kind of /dev/null type of destination is feasible and that is what people end up d

Re: Detoasting optionally to make Explain-Analyze less misleading

2024-02-26 Thread stepan rutz
Hi Matthias, thanks for picking it up. I still believe this is valuable to a lot of people out there. Thanks for dealing with my proposal. Matthias, Tom, Tomas everyone. Two (more or less) controversial remarks from side. 1. Actually serialization should be the default for "analyze" in explain,

Re: Detoasting optionally to make Explain-Analyze less misleading

2023-11-02 Thread stepan rutz
nting the bytes gives an impression of what would go over the wire. Only the big numbers matter here of course. Regards, Stepan On 02.11.23 20:32, Tomas Vondra wrote: On 11/2/23 20:09, stepan rutz wrote: Hi Thomas, you are right of course. Thanks! I have attached a new version of the patch

Re: Detoasting optionally to make Explain-Analyze less misleading

2023-11-02 Thread stepan rutz
ll1(3166...) to invoke it. Otherwise I'd say it would be nice if the code from that function would be made available as a utility function for all c-code.  Any suggestions on this topic? Regards, /Stepan On 02.11.23 18:49, Tomas Vondra wrote: Hi, On 9/15/23 22:09, stepan rutz wrote: Hi,

Re: Detoasting optionally to make Explain-Analyze less misleading

2023-09-15 Thread stepan rutz
is a good thing for sure. Greetings, Stepan On 14.09.23 21:27, stepan rutz wrote: Hi Tom, Hi Matthias, you are right of course. I have looked at the code from printtup.c and made a new version of the patch. Thanks for the MemoryContextReset hint too (@Matthias) This time is called  EXPLA

Re: Detoasting optionally to make Explain-Analyze less misleading

2023-09-14 Thread stepan rutz
Hi Tom, Hi Matthias, you are right of course. I have looked at the code from printtup.c and made a new version of the patch. Thanks for the MemoryContextReset hint too (@Matthias) This time is called  EXPLAIN(ANALYZE,SERIALIZE) (hey, it also sounds nicer phonetically) If the option SERIALIZE i

Re: Detoasting optionally to make Explain-Analyze less misleading

2023-09-12 Thread stepan rutz
I explain (analyze) select * into This is the call I am talking about, which was missing from explain.c   dest->rDestroy(dest); Attached a new patch. Hoping for feedback, Greetings, Stepan On 12.09.23 14:25, Matthias van de Meent wrote: On Tue, 12 Sept 2023 at 12:56, stepan rutz w

Detoasting optionally to make Explain-Analyze less misleading

2023-09-12 Thread stepan rutz
on the subject and how to address this, maybe in totally different ways. Greetings from cologne, Stepan Stepan Rutz - IT Consultant, Cologne Germany, stepan.rutz AT gmx.de diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c index 8570b14f62..50859e6a1e 100644 --- a/src/b