Re: [Bug Fix]standby may crash when switching-over in certain special cases

2024-12-27 Thread px shi
pinLockRelease(&walsnder->mutex); } } SpinLockRelease(&walsnd->mutex); } Regards, Pixian Shi px shi 于2024年10月10日周四 15:01写道: > Although I've not tested it because I don't have good way to reproduce >> the problem > > > &

Re: a litter question about mdunlinkfiletag function

2024-10-14 Thread px shi
FORKNUM when calling relpathperm(). While mdunlinkfiletag currently only handles MAIN_FORKNUM, wouldn’t it be more flexible to retrieve the forknum from the ftag structure instead? Bruce Momjian 于2024年10月15日周二 04:59写道: > On Mon, Sep 30, 2024 at 10:43:17AM +0800, px shi wrote: > > Hi,

Re: Remove unlogged materialized view persistence handling

2024-10-10 Thread px shi
> > +1 > > Materialized view is introduced by 3bf3ab8c563 and at that UNLOGGED was > allowed, and it is disallowed by another commit 3223b25ff73. However, > it seems that the tab-complement is missed to fixed. > > The Assert for RELKIND_MATVIEW in heapam_hander.c was introduced in > d25f519107b > a

Remove unlogged materialized view persistence handling

2024-10-10 Thread px shi
Hi, Since materialized views do not support the unlogged type, I think that we should remove the logic and handling related to unlogged. Therefore, I have submitted a patch. Regards, Pixian Shi 0001-Remove-unlogged-materialized-view-persistence-handli.patch Description: Binary data

Re: [Bug Fix]standby may crash when switching-over in certain special cases

2024-10-10 Thread px shi
w patch has been submitted. Regards, Pixian Shi Yugo NAGATA 于2024年10月9日周三 14:46写道: > On Mon, 30 Sep 2024 15:14:54 +0800 > px shi wrote: > > > Thanks for responding. > > > > > > > It is odd that the standby server crashes when > > > > replication

Re: [Bug Fix]standby may crash when switching-over in certain special cases

2024-09-30 Thread px shi
nd causing the startup process to PANIC. Regards, Pixian Shi Yugo NAGATA 于2024年9月30日周一 13:47写道: > On Wed, 21 Aug 2024 09:11:03 +0800 > px shi wrote: > > > Yugo Nagata 于2024年8月21日周三 00:49写道: > > > > > > > > > > > > Is s1 a cascading standby of

a litter question about mdunlinkfiletag function

2024-09-29 Thread px shi
*Hi, hackers* *When calculating the path, *forknum* is hardcoded as *MAIN_FORKNUM*:* /* Compute the path. */ p = relpathperm(ftag->rnode, MAIN_FORKNUM); *But since the *ftag* structure already contains *forknum*:* typedef struct FileTag { int16 handler; /* SyncRequestHandler value, saving space

Re: [Bug Fix]standby may crash when switching-over in certain special cases

2024-08-20 Thread px shi
Yugo Nagata 于2024年8月21日周三 00:49写道: > > > > Is s1 a cascading standby of s2? If otherwise s1 and s2 is the standbys > of > > the primary server respectively, it is not surprising that s2 has > progressed > > far than s1 when the primary fails. I believe that this is the case you > should > > use p

[Bug Fix]standby may crash when switching-over in certain special cases

2024-08-19 Thread px shi
Hi, hackers, I've recently encountered an issue where a standby crashes when reconnecting to a new primary after a switchover under certain conditions. Here's a procedure of the crash scenario: 1) We have three instances: one primary and two standbys (s1 and s2, both using streaming replication)

CREATE MATERIALIZED VIEW

2024-07-25 Thread px shi
Hi, I see that materialized view cannot be unlogged now, but when I use psql and type CREATE UNLOGGED, pressing the Tab key for auto-completion suggests `TABLE` and MATERIALIZED VIEW. Shouldn't `MATERIALIZED VIEW ` be suggested?