Fix error message for MERGE foreign tables

Hi, MERGE command does not accept foreign tables as targets. When a foreign table is specified as a target, it shows error messages like this: -- ERROR: cannot execute MERGE on relation "child1" -- DETAIL: This operation is not supported for foreign tables. However, when a partitioned table

Re: Make ON_ERROR_STOP stop on shell script failure

There was a mistake in the error message for \! so I updated the patch. Best, Tatsuhiro Nakamoridiff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml index 9494f28063..82febf0ace 100644 --- a/doc/src/sgml/ref/psql-ref.sgml +++ b/doc/src/sgml/ref/psql-ref.sgml @@ -4143,7 +41

Re: ps command does not show walsender's connected db

2022-10-10 16:12 Bharath Rupireddy wrote: Thanks. LGTM. Thank you for your review! I have this issue posted on Commitfest 2022-11 with title "show walsender's connected db for ps command entry". May I change the status to "Ready for Committer"? Best, Tatsuhiro Nakamori

Re: ps command does not show walsender's connected db

2022-10-10 12:27 Bharath Rupireddy wrote: if (port->database_name != NULL && port->database_name[0] != '\0') appendStringInfo(&ps_data, "%s ", port->database_name); The above works better. Thank you for the suggestion. I have edited the patch to reflect your idea. Best, Tatsuhiro Nakamori

Re: ps command does not show walsender's connected db

2022-10-09 18:30 Bharath Rupireddy wrote: -if (!am_walsender) +if (!am_walsender || am_db_walsender) appendStringInfo(&ps_data, "%s ", port->database_name); Can the appendStringInfo be just unconditional? That is more readable IMO. We want the database_name to be appended whenev

Re: Make ON_ERROR_STOP stop on shell script failure

2022-10-07 17:16 Fujii Masao wrote: The patch failed to be applied into the master cleanly. Could you rebase it? patching file src/bin/psql/common.c Hunk #1 succeeded at 94 (offset 4 lines). Hunk #2 succeeded at 104 (offset 4 lines). Hunk #3 succeeded at 133 (offset 4 lines). Hunk #4 succeeded

Re: ps command does not show walsender's connected db

2022-10-07 16:59 Fujii Masao wrote: s/subscriber/publisher ? I did not understand what this means. Thanks for the patch! - + printf("fork child process\n"); + printf(" am_walsender: %d\n", am_walsender); + printf(" am_db_walsender: %d\n", am_db

ps command does not show walsender's connected db

Hi, When walsender process is evoked for logical replication, walsender is connected to a database of the subscriber. Naturally, ones would want the name of the connected database to show in the entry of ps command for walsender. In detail, running ps aux during the logical replication shows re

JUMBLE_SIZE macro in two files

Hi, queryjumble.c and queryjumble.h both define a macro JUMBLE_SIZE = 1024. Since queryjumble.c includes queryjumble.h, the JUMBLE_SIZE definition in queryjumble.c should be deleted. Thoughts? Tatsudiff --git a/src/backend/utils/misc/queryjumble.c b/src/backend/utils/misc/queryjumble.c index a

Re: Make ON_ERROR_STOP stop on shell script failure

2022-09-21 11:45 に Fujii Masao wrote: We can execute the shell commands via psql in various ways other than \! meta-command. For example, * `command` * \g | command * \gx | command * \o | command * \w | command * \copy ... program 'command' ON_ERROR_STOP should handle not only \! but also all t

Re: Make ON_ERROR_STOP stop on shell script failure

2022-09-28 21:49 に torikoshia さんは書きました: if (result == 127 || result == -1) { pg_log_error("\\!: failed"); return false; } else if (result != 0) { pg_log_error("command failed"); return false; Since it would be hard to understand the cause of failures from

Re: Differentiate MERGE queries with different structures

2022-09-27 17:48 に Alvaro Herrera さんは書きました: Pushed, thanks. The code and the tests went fine on my environment. Thank you Alvaro for your help, and thank you Julien for your review! Best, Tatsuhiro Nakamori

Differentiate MERGE queries with different structures

Hi, pg_stat_statements module distinguishes queries with different structures, but some visibly different MERGE queries were combined as one pg_stat_statements entry. For example, MERGE INTO test1 USING test2 ON test1.id = test2.id WHEN MATCHED THEN UPDATE var = 1; MERGE INTO test1 USING test

Re: Make ON_ERROR_STOP stop on shell script failure

2022-09-17 09:44 に bt22nakamorit さんは書きました: 2022-09-16 17:30 に Kyotaro Horiguchi さんは書きました: At Fri, 16 Sep 2022 15:55:33 +0900, bt22nakamorit wrote in Hi, """\set ON_ERROR_STOP on""" stops any subsequent incoming query that comes after an error of an SQL, b

Re: Make ON_ERROR_STOP stop on shell script failure

2022-09-16 17:30 に Kyotaro Horiguchi さんは書きました: At Fri, 16 Sep 2022 15:55:33 +0900, bt22nakamorit wrote in Hi, """\set ON_ERROR_STOP on""" stops any subsequent incoming query that comes after an error of an SQL, but does not stop after a shell script ran by &q

Make ON_ERROR_STOP stop on shell script failure

Hi, """\set ON_ERROR_STOP on""" stops any subsequent incoming query that comes after an error of an SQL, but does not stop after a shell script ran by """\! """ returning values other than 0, -1, or 127, which suggests a failure in the result of the shell script. For example, suppose that be