n the
single-page HTML output (make postgres.html), even though the
generated HTML source code looks correct. Maybe someone has an idea
there.
I feel responsible for the feature to work for all use cases where it
makes sense. I'll investigate this and post back.
Regards,
Brar
On 06.04.2023 at 11:06, Peter Eisentraut wrote:
On 04.04.23 21:52, Brar Piening wrote:
The XSLT implementation looks sound to me. It would be a touch better
if it had some comments about which parts of the templates were copied
from upstream stylesheets and which were changed. There are
een the website and the documentation
sources. You can produce the exact same DOM, that part seems okay,
just do it elsewhere. Was this approach considered? I didn't see it
in the thread.
I briefly touched the topic in [1] and [2] but we didin't really follow
up on the best appro
On 29.03.2023 at 06:52, Hayato Kuroda (Fujitsu) wrote:
FYI - my patch is pushed
Thanks!
Could you please rebase your patch?
Done and tested. Patch is attached.
Regards,
Brar
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index fcb53c6997..5c50347c58 100644
--- a/doc
ke it as easy as possible
for a potential committer and I'm happy to rebase my patch upon request
or if Kuroda-san's patch gets applied first.
Regards,
Brar
On 23.03.2023 at 20:08, Brar Piening wrote:
Since the need for ids is starting to grow again (ecb696527c added an
id to a varlistentry in doc/src/sgml/ref/create_subscription.sgml)
I've also amended the add-needed-ids patch once again so that the
build does not fail after applyin
ad...
For those trying to follow the thread in the archives: my response (it's
probably a refsect which isn't supported yet) ended up here:
https://www.postgresql.org/message-id/1N1fn0-1qd4xd1MyG-011ype%40mail.gmx.net
Regards,
Brar
not add links for yet.I already have plans to add this
> in a follow-up patch at some point, but while I had already added ids to all
> section elements in the previous patch that added ids, this has yet to be
> done for all refsect elements (wich is not a small effort again).Regards,Brar
On 24.03.2023 at 06:48, Brar Piening wrote:
Since (after tweaking the color) the general visual appearence looked
ok to me, I didn't bother with this any further.
Also, if we go on with this we'll probably end up in an almost
prototypical bikeshedding scenario where PostgreSQL its
On 24.03.2023 at 05:09, Karl O. Pinc wrote:
Hi Brar,
An observation: The # that shows up when hovering
over section-level headings is styled as the
section-level heading is. But the # that shows
up when hovering over varlistentrys has the default
text style.
This works for me. It's ni
On 23.03.2023 at 23:31, Karl O. Pinc wrote:
Hi Brar,
It occurs to me that I had not actually tested the
way the anchor is put only after the last term in a
varlistentry. (The code looked obviously right
and should work if any varlistentry terms have anchors,
which they do, but)
Have you
an intentional decision we
can theoretically soften this by only issuing a warning or removing the
check for missing id's altogether but this would probably defeat the
purpose since it would lead to an increasing number of entries that lack
an id after a while.
Regards,
Brar
diff --git a/doc/src/sgml/
On 23.03.2023 at 10:35, Alvaro Herrera wrote:
As with the patch, we'll need to patch the CSS used in the
website for the docs too, as that's the most important place where docs
are visited. See this commit for an example:
https://git.postgresql.org/gitweb/?p=pgweb.git;a=commitdiff;h=0b89ea0fff2
gresql.org/message-id/e50193ea-ca5c-e178-026a-f3fd8942252d%40gmx.de
Personally I'd advise to stick with ASCII for now.
In any case changing the symbol at some point would be a very minor
effort if we deem it necessary.
Maybe this could be part of some general overhaul of the visual
apperance and website styling by a person with more talent for this than
I have.
Regards,
Brar
he length of
the patch (it's a bit nicer though since in this case it really avoids
duplication). I've also taken the advice to terminate the build and
print the xpath if a required id is missing.
The attached patch is my best-effort approach to implement discoverable
links.
Best regards,
On 20.03.2023 at 19:47, Gregory Stark (as CFM) wrote:
Looks like a lot of good work was happening on this patch right up
until mid-February. Is there a lot of work left? Do you think you'll
have a chance to wrap it up this commitfest for this release?
Thanks for the ping.
I had another look th
On 18.01.2023 at 06:50, Brar Piening wrote:
I'll give it a proper look this weekend.
It turns out I didn't get a round tuit.
... and I'm afraid I probably will not be able to work on this until
mid/end February so we'll have to move this to the next commitfest until
someb
t; the section.heading template
and adds extra stuff to the HTML output generated by the stock
template. (example_section_heading_override.patch)
Thanks!
I'll give it a proper look this weekend.
Regards,
Brar
arning by doing combined with trial and error.
Regards,
Brar
t and it sounds
like you want me to write a customization layer which I didn't do
because there is precedent that the typical "way to do it" (TM) in the
PostgreSQL project is [2].
Regards,
Brar
[1] http://www.sagehill.net/docbookxsl/CustomizingPart.html
[2] http://www.sagehill.net/docbookxsl/ReplaceTemplate.html
nces in contrib.sgml that in
general looks like an improvment to me.
In conclusion I cannot see why this patch should not be applied in it's
current form so I deem it ready for commiter.
Regards,
Brar
sider it a pretty opaque string that is
meant for copy-paste from a browser to some editing window.
It is all in our head and as a matter of fact we could be using UUIDs as
Ids and save us from any further consistency issues. It's just that they
look so ugly.
You'd have to ask Brar
On 10.01.2023 at 06:28, Brar Piening wrote:
I'll repost a rebased version of the styling patch in a minute.
After checking that there's no need for rebasing I'm reposting the
original patch here, to make cfbot pick it up as the latest one in a
somewhat screwed up thread mix
st a rebased version of the styling patch in a minute.
Regards,
Brar
going to start whining that the patch-of-record in
this thread no longer applies.
I will do that. Thanks for your feedback!
Regards,
Brar
commitfest.postgresql.org/41/4042/ is tracking a different patch
that makes the ids and the corresponding links discoverable at the HTML
surface. Hover one of the psql options in [2] to see the behavior. This
one still needs reviewing and there is no discussion around it yet.
Regards,
Brar
[1]
h
On 02.01.2023 at 21:53, Karl O. Pinc wrote:
If the author will look over my version of the patch I believe it can
be approved and sent on to the committers.
LGTM.
Thanks!
Brar
On 06.12.2022 at 19:11, Brar Piening wrote:
The current statistics for docbook elements with/without ids after
applying the patch are the following:
Somehow my e-mail client destroyed the table. That's how it was supposed
to look like:
name | with_id | without_id | id_cov
On 06.12.2022 at 18:59, Brar Piening wrote:
On 06.12.2022 at 09:38, Alvaro Herrera wrote:
I would welcome separate patches: one to add the IDs, another for the
XSL/CSS stuff. That allows us to discuss them separately.
I'll send two patches in two separate e-mails in a moment.
This is
our second link should work now.
It'll probably have some conflicts, yeah.
I've updated and rebased my branch on current master now.
I would welcome separate patches: one to add the IDs, another for the
XSL/CSS stuff. That allows us to discuss them separately.
I'll send two patches in two separate e-mails in a moment.
Regards,
Brar
them more discoverable in the browser but I had gotten the
impression that nobody besides me cares about this, so I didn't push it
any further.
Brar, would you like to add an entry so they don't get
lost? See: https://commitfest.postgresql.org/41/
Yes. I can certainly add them to
On 09.03.2022 at 20:43, Brar Piening wrote:
Attached is a pretty huge patch that adds ids to all sections and all
the varlistentries where the containing variablelist already had at
least one id (plus a few additional ones that I stumbled upon and
deemed useful). It also adds html links next to
On 02.03.2022 at 18:54, Chapman Flack wrote:
Perhaps there are a bunch of variablelists where no one cares about
linking to any of the entries.
So maybe a useful non-terminating message to add eventually would
be one that identifies any varlistentry lacking an id, with a
variablelist where at le
On 02.03.2022 at 10:37, Peter Eisentraut wrote:
I have applied the part of your patch that adds the id's. The
discussion about the formatting aspect can continue.
Thank you!
I've generated some data by outputting the element name whenever a
section or varlistentry lacks an id. That's how the
On Mar 01, 2022 at 18:27, Brar Piening wrote:
On Feb 28, 2022 at 21:06, Chapman Flack wrote:
I think that in other recent examples I've seen, there might be
(something like a) consensus forming around the Unicode LINK SYMBOL
🔗 rather than # as the symbol for such things.
I intentio
On Feb 28, 2022 at 21:06, Chapman Flack wrote:
I think that in other recent examples I've seen, there might be
(something like a) consensus forming around the Unicode LINK SYMBOL
🔗 rather than # as the symbol for such things.
I intentionally opted for an ASCII character as that definitely won't
On Feb 25, 2022 at 06:36, Brar Piening wrote:
The major problem in that regard would probably be my lack of
XSLT/docbook skills but if no one can jump in here, I can see if I can
make it work.
Ok, I've figured it out.
Attached is an extended version of the patch that changes the XSL an
On 28.02.2022 at 10:24, Peter Eisentraut wrote:
On 28.02.22 09:41, Brar Piening wrote:
On Feb 25, 2022 at 14:31, Peter Eisentraut wrote:
I think that kind of stuff would be added in via the web site
stylesheets, so you wouldn't have to deal with XSLT at all.
True for the CSS but addin
On Feb 25, 2022 at 14:31, Peter Eisentraut wrote:
I think that kind of stuff would be added in via the web site
stylesheets, so you wouldn't have to deal with XSLT at all.
True for the CSS but adding the HTML (#)
will need either XSLT or Javascript.
On 24.02.2022 at 17:07, Brar Piening wrote:
On 24.02.2022 at 16:46, Alvaro Herrera wrote:
Would it be possible to create such anchor links as part of the XSL
stylesheets for HTML?
I'll investiogate our options and report back.
Yes, that would be possible. In fact appending a lin
On 24.02.2022 at 16:46, Alvaro Herrera wrote:
On 2022-Feb-24, Dagfinn Ilmari Mannsåker wrote:
Peter Eisentraut writes:
Is there a way to obtain those URLs other than going into the HTML
sources and checking if there is an anchor near where you want go?
I use the jump-to-anchor extension: htt
On 20.12.2021 at 16:09, Robert Haas wrote:
As a data point, this is something I have also wanted to do, from time
to time. I am generally of the opinion that any place the
documentation has a long list of things, which should add ids, so that
people can link to the particular thing in the list to
On Dec 17, 2021 at 08:13, Peter Eisentraut wrote:
On 15.12.21 16:59, Brar Piening wrote:
On Dec 15, 2021 at 15:49, Alvaro Herrera wrote:
On 2021-Dec-15, Brar Piening wrote:
Since I can't argue towards some general utility for the xreflabels
and don't have any other solid argument i
On Dec 15, 2021 at 15:49, Alvaro Herrera wrote:
On 2021-Dec-15, Brar Piening wrote:
Since I can't argue towards some general utility for the xreflabels
and don't have any other solid argument in favor of adding more, I
will remove them from my current patch but leave the existing o
On Dec 14, 2021 at 20:47, Alvaro Herrera wrote:
Hmm, I think we tend to avoid xreflabels; see
https://www.postgresql.org/message-id/8315c0ca-7758-8823-fcb6-f37f9413e...@2ndquadrant.com
Ok, thank you for the hint.
I added them because doesn't automatically generate
labels and they were present
lements in protocol.sgml to
make them more accesssible via the public html documentation interface.
I've tried to follow the style that was already there in a few of the
elements.
Do you consider this useful and worth merging?
Is there anything I can improve?
Best Regards,
Brar
diff --git
Amit Kapila schrieb:
On Mon, Jun 21, 2021 at 4:13 PM Brar Piening wrote:
Amit Kapila wrote:
After looking at the docs once again I have another minor amendment (new
patch attached).
+The value of the column, eiter in binary or in text format.
Typo. /eiter/either
Fixed
Amit Kapila wrote:
On Mon, Jun 21, 2021 at 12:26 PM Brar Piening wrote:
Hello Hackers,
while amending Npgsql to account for the Logical Streaming Replication
Protocol changes in PostgreSQL 14 I stumbled upon two documentation
inaccuracies in the Logical Replication Message Formats
replication/logicalproto.h#L83
and
https://github.com/postgres/postgres/blob/69a58bfe4ab05567a8fab8bdce7f3095ed06b99c/src/backend/replication/logical/proto.c#L558.
The attached documentation patch fixes both.
Best regards,
Brar
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/
!
Brar
d without over-engineering the problem or causing any
backwards-compatibility issues.
Regards,
Brar Piening
Bruce Momjian wrote:
>> Good point. The reporter was assuming the data would come to the client
>> in the bytea output format specified by the GUC, e.g. \x..., so that
>> doesn't happen either. As I said before, it is more raw bytes, but we
>> don't have an SQL data type for that.
> I did some mo
ency on an undocumented implementation
detail that could possibly change at any point.
Regards,
Brar
Brar Piening wrote:
> This is certainly a minor problem
After thinking about it a little more I think that at least the fact
that even the row description message advertises the content as bytea
could be considered as a bug - no?
54 matches
Mail list logo
