Re: Fix a typo in walsender.c

2018-03-28 Thread atorikoshi
On 2018/03/29 7:23, Bruce Momjian wrote: Thanks, patch applied. Thank you for committing!

Fix a typo in walsender.c

2018-02-27 Thread atorikoshi
Hi, Attached a minor patch for a typo: s/log/lag Regards, -- Atsushi Torikoshi NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index d46374d..8bb1919 100644 --- a/src/backend/repli

Re: Fix a typo in walsender.c

2018-02-08 Thread atorikoshi
On 2018/02/09 4:40, Robert Haas wrote: On Thu, Feb 8, 2018 at 1:32 AM, atorikoshi wrote: Attached a minor patch for variable name in comment: Committed. Thank you!

Fix a typo in walsender.c

2018-02-07 Thread atorikoshi
Hi, Attached a minor patch for variable name in comment: s/progress_update/update_progress ---include/server/replication/logical.h ... 35 typedef struct LogicalDecodingContext 36 { ... 68 LogicalOutputPluginWriterUpdateProgress update_progress; Regards, -- Atsushi Torikoshi NIPP

Re: User defined data types in Logical Replication

2018-01-30 Thread atorikoshi
Hi, It seems to be in the middle of discussion, but I became a reviewer of this problem several days ago so I've tested the latest patch 'fix_slot_store_error_callback_v12.patch'. I reproduced the below ERROR by inserting elog() to INPUT function of CREATE TYPE, and confirmed that above patch so

Re: Failed to delete old ReorderBuffer spilled files

2018-01-09 Thread atorikoshi
On 2018/01/06 0:30, Alvaro Herrera wrote: Ahh, so the reason I didn't see these crashes is that Atsushi had already fixed them. Nice. It would be *very* good to trim the quoted material when you reply --- don't leave everything, just enough lines for context. I would have seen this comment if

Re: Failed to delete old ReorderBuffer spilled files

2017-11-23 Thread atorikoshi
On 2017/11/24 10:57, Craig Ringer wrote: > On 24 November 2017 at 09:20, atorikoshi >> wrote: > >> >> Thanks for letting me know. >> I think I only tested running "make check" at top directory, sorry >> for my insufficient test. >> >>

Re: Failed to delete old ReorderBuffer spilled files

2017-11-23 Thread atorikoshi
at 18:35, atorikoshi wrote: I put many queries into one transaction and made ReorderBuffer spill data to disk, and sent SIGKILL to postgres before the end of the transaction. After starting up postgres again, I observed the files spilled to data wasn't deleted. Since this can only happe

Re: Failed to delete old ReorderBuffer spilled files

2017-11-21 Thread atorikoshi
Thanks for reviewing! On 2017/11/21 18:12, Masahiko Sawada wrote: On Tue, Nov 21, 2017 at 3:48 PM, Masahiko Sawada wrote: On Mon, Nov 20, 2017 at 7:35 PM, atorikoshi wrote: Hi, I put many queries into one transaction and made ReorderBuffer spill data to disk, and sent SIGKILL to postgres

Failed to delete old ReorderBuffer spilled files

2017-11-20 Thread atorikoshi
Hi, I put many queries into one transaction and made ReorderBuffer spill data to disk, and sent SIGKILL to postgres before the end of the transaction. After starting up postgres again, I observed the files spilled to data wasn't deleted. I think these files should be deleted because its transac