Re: Physical replication slot advance is not persistent

2020-01-20 Thread a . kondratov
On 20 Jan 2020, 09:45 +0300, Michael Paquier , wrote: > > So, I have been looking at this patch by myself, and updated it so as > the extra slot save is done only if any advancing has been done, on > top of the other computations that had better be around for > consistency. The patch includes TAP t

Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)

2019-09-25 Thread a . kondratov
On 2019-09-25 20:48, Alvaro Herrera wrote: CC Alexey for reasons that become clear below. Another thing in 0002 is that you're adding a "-R" switch to pg_rewind, but we have another patch in the commitfest using the same switch for a different purpose. Maybe you guys need to get to an agreement

Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

2019-08-31 Thread a . kondratov
Hi hackers, On 2018-12-27 04:57, Michael Paquier wrote: On Wed, Dec 26, 2018 at 03:19:06PM -0300, Alvaro Herrera wrote: As for REINDEX, I think it's valuable to move tablespace together with the reindexing. You can already do it with the CREATE INDEX CONCURRENTLY recipe we recommend, of course

Re: row filtering for logical replication

2019-08-27 Thread a . kondratov
Hi Euler, On 2019-02-03 13:14, Andres Freund wrote: On 2018-11-23 13:15:08 -0300, Euler Taveira wrote: Besides the problem presented by Hironobu-san, I'm doing some cleanup and improving docs. I also forget to declare pg_publication_rel TOAST table. Thanks for your review. As far as I can t

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

2019-01-21 Thread a . kondratov
Hi Andrey, Thank you for the review! I have updated the patch according to your comments and remarks. Please, find new version attached. On 2019-01-07 12:12, Andrey Borodin wrote: Here are some my notes: 1. RestoreArchivedWAL() shares a lot of code with RestoreArchivedFile(). Is it possible\vi