Re: Custom connstr in background_psql()

2024-09-19 Thread a . imamov
Michael Paquier писал(а) 2024-09-18 01:57: On Wed, Sep 18, 2024 at 01:08:26AM +0300, a.ima...@postgrespro.ru wrote: I've noticed that there is no way to specify a custom connection string when calling the PostgreSQL::Test::Cluster->background_psql() method compared to the PostgreSQL::Test:Clust

Custom connstr in background_psql()

2024-09-17 Thread a . imamov
Hi, hackers! I've noticed that there is no way to specify a custom connection string when calling the PostgreSQL::Test::Cluster->background_psql() method compared to the PostgreSQL::Test:Cluster->psql(). It seems useful to have this feature while testing with BackgroundPsql, for example, when

Re: Potential issue in ecpg-informix decimal converting functions

2024-03-06 Thread a . imamov
Daniel Gustafsson писал(а) 2024-03-06 18:03: On 27 Feb 2024, at 06:08, Michael Paquier wrote: On Mon, Feb 26, 2024 at 12:28:51AM +0100, Daniel Gustafsson wrote: Yeah, I think this is for HEAD only, especially given the lack of complaints against backbranches. Daniel, are you planning to loo

Re: Potential issue in ecpg-informix decimal converting functions

2024-02-29 Thread a . imamov
Michael Paquier писал(а) 2024-02-28 02:14: On Tue, Feb 27, 2024 at 09:24:25AM +0100, Daniel Gustafsson wrote: I have it on my TODO for the upcoming CF. Okay, thanks. -- Michael Greetings! Sorry, I had been waiting for a few days for my cool-off period to end. The patch now is registered to

Re: Potential issue in ecpg-informix decimal converting functions

2024-02-23 Thread a . imamov
Daniel Gustafsson писал(а) 2024-02-23 13:44: On 22 Feb 2024, at 17:54, a.ima...@postgrespro.ru wrote: PGTYPESnumeric_to_int() and PGTYPESnumeric_to_long() functions return only 0 or -1. So ECPG_INFORMIX_NUM_OVERFLOW can never be returned. Indeed, this looks like an oversight. I think decto

Potential issue in ecpg-informix decimal converting functions

2024-02-22 Thread a . imamov
Hi, everyone! I found a potential bug in dectoint() and dectolong() functions from informix.c. "Informix Compatibility Mode" doc chapter says that ECPG_INFORMIX_NUM_OVERFLOW is returned if an overflow occurred. But check this line in dectoint() or dectolong() (it is present in both): if (ret == P