Re: Check for existing replication slot in pg_createsubscriber

2025-06-29 Thread Zane Duffield
On Mon, Jun 30, 2025 at 1:15 PM Amit Kapila wrote: > One thing I was > thinking is whether it makes sense to add these checks only in > --dry-run mode because we normally don't expect such conflicts. > Otherwise, each such check adds an additional network round-trip. > I did wonder why it bother

Re: Check for existing replication slot in pg_createsubscriber

2025-06-29 Thread Zane Duffield
On Mon, Jun 30, 2025 at 1:01 PM Amit Kapila wrote: > > I see the difference you are pointing to. Ideally, the checks should > be the same unless there is a specific reason for them to be > different, which should be mentioned in the comments. BTW, do you see > any problems due to name conflicts w

Check for existing replication slot in pg_createsubscriber

2025-06-27 Thread Zane Duffield
Hackers, I noticed in testing and usage that pg_createsubscriber doesn't check for an existing replication slot before attempting to create one, whereas it *does* check for existing publications. If it were to check for an existing replication slot, then the --dry-run mode would be able to detect