On Thu, Jun 1, 2023 6:54 PM Melih Mutlu wrote:
>
> Hi,
>
> I rebased the patch and addressed the following reviews.
>
Thanks for updating the patch. Here are some comments on 0001 patch.
1.
- ereport(LOG,
- (errmsg("logical replication table synchronization
worker
On Wed, May 31, 2023 5:41 PM shveta malik wrote:
>
> On Mon, May 29, 2023 at 11:45 AM Yu Shi (Fujitsu)
> wrote:
> >
> > 0008 patch
> > -
> > 4.
> > case AT_AddColumn:
> > /* XXX
On Wed, May 31, 2023 5:41 PM shveta malik wrote:
>
> PFA the set of patches consisting above changes. All the changes are
> made in 0008 patch.
>
> Apart from above changes, many partition attach/detach related tests
> are uncommented in alter_table.sql in patch 0008.
>
Thanks for updating the
On Monday, May 29, 2023 5:22 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 5/26/23 9:27 AM, Yu Shi (Fujitsu) wrote:
> > Hi hackers,
> >
> > I saw a buildfarm failure on "dikkop"[1]. It failed in
> > 035_standby_logical_decoding.pl, be
On Mon, May 22, 2023 1:57 PM shveta malik wrote:
>
> Please find the new set of patches for object-tree Removal. The new
> changes are in patch 0008 only. The new changes address object tree
> removal for below commands.
>
> create sequence
> alter sequence
> alter object owner to
> alter obje
Hi hackers,
I saw a buildfarm failure on "dikkop"[1]. It failed in
035_standby_logical_decoding.pl, because the slots row_removal_inactiveslot and
row_removal_activeslot are not invalidated after vacuum.
regress_log_035_standby_logical_decoding:
```
[12:15:05.943](4.442s) not ok 22 - inactiveslot
On Thu, Apr 27, 2023 9:53 PM Amit Kapila wrote:
>
> On Thu, Apr 27, 2023 at 4:07 PM Drouvot, Bertrand
> wrote:
> >
> > On 4/27/23 11:53 AM, Amit Kapila wrote:
> > > On Thu, Apr 27, 2023 at 2:16 PM Drouvot, Bertrand
> > > wrote:
> > >>
On Thu, Apr 27, 2023 4:47 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 4/27/23 10:11 AM, Yu Shi (Fujitsu) wrote:
> > Hi hackers,
> >
> > In 035_standby_logical_decoding.pl, I think that the check in the following
> > test
> > case should be performed o
Hi hackers,
In 035_standby_logical_decoding.pl, I think that the check in the following test
case should be performed on the standby node, instead of the primary node, as
the slot is created on the standby node. The test currently passes because it
only checks the return value of psql. It might be
On Mon, Apr 24, 2023 8:07 PM Drouvot, Bertrand
wrote:
>
> On 4/24/23 11:45 AM, Amit Kapila wrote:
> > On Mon, Apr 24, 2023 at 11:54 AM Amit Kapila
> wrote:
> >>
> >> On Mon, Apr 24, 2023 at 11:24 AM Drouvot, Bertrand
> >> wrote:
> >>>
> >>
> >> Few comments:
> >>
> >>
> >
> > +# W
On Fri, Apr 21, 2023 1:48 PM Yu Shi (Fujitsu) wrote:
>
> I wrote a patch to dump rel state in wait_for_subscription_sync() as
> suggested.
> Please see the attached patch.
> I will try to add some debug logs in code later.
>
Please see the attached v2 patch.
I added so
On Tue, Jan 24, 2023 7:41 PM Amit Kapila wrote:
>
> On Tue, Jan 24, 2023 at 8:53 AM Andres Freund wrote:
> >
> > cfbot, the buildfarm and locally I have seen 100_bugs.pl fail
> > occasionally. Just rarely enough that I never got around to looking into it
> > for real.
> >
> ...
> >
> > We see t2
On Fri, Apr 7, 2023 11:23 AM houzj.f...@fujitsu.com
wrote:
>
> On Friday, April 7, 2023 11:13 AM houzj.f...@fujitsu.com
>
> >
> > On Tuesday, April 4, 2023 7:35 PM shveta malik
> > wrote:
> > >
> > > On Tue, Apr 4, 2023 at 8:43 AM houzj.f...@fujitsu.com
> > > wrote:
> > >
> > > > Attach the n
On Fri, Mar 24, 2023 6:26 AM Tom Lane wrote:
>
> I do see a docs change that I think would be worth making: get
> rid of the explicit mention of it in create_subscription.sgml
> in favor of using that view.
>
I agree and I tried to modify the query to use the view.
Please see the attached patch
14 matches
Mail list logo
