Re: Current master hangs under the debugger after Parallel Seq Scan (Linux, MacOS)

2025-04-05 Thread Vladlen Popolitov
Tom Lane писал(а) 2025-03-26 22:38: Vladlen Popolitov writes: d) Above query will start parallel worker(s). When worker(s) finish(es), it/they send SIGUSR1 that is caught by debugger. When you dimiss the signal message, you find that query continues to run, but really it waits (in latch.c

Re: Current master hangs under the debugger after Parallel Seq Scan (Linux, MacOS)

2025-04-05 Thread Vladlen Popolitov
ou for pointing, that it more relates to a debugger than Postgres. Both extensions process signals internally and do not expose the handlers in settings. Thank you for your support and time. -- Best regards, Vladlen Popolitov.

Current master hangs under the debugger after Parallel Seq Scan (Linux, MacOS)

2025-04-05 Thread Vladlen Popolitov
ced on Linux and MacOS. Also I afraid, the same behaviour will be for other types of parallel workers under debugger (Parallel Hash etc). -- Best regards, Vladlen Popolitov.

Re: Remove useless casts to (char *)

2025-03-26 Thread Vladlen Popolitov
Michael Paquier писал(а) 2025-03-27 05:20: On Wed, Mar 26, 2025 at 10:01:47PM +0700, Vladlen Popolitov wrote: I mentioned this patch in my message https://www.postgresql.org/message-id/f28f3b45ec84bf9dc99fe129023a2d6b%40postgrespro.ru Starting from it queries with Parallel Seq Scan (probably

Re: Remove useless casts to (char *)

2025-03-26 Thread Vladlen Popolitov
/f28f3b45ec84bf9dc99fe129023a2d6b%40postgrespro.ru Starting from it queries with Parallel Seq Scan (probably with other parallel executor nodes) hang under the debugger in Linux and MacOs. -- Best regards, Vladlen Popolitov.

Re: PoC. The saving of the compiled jit-code in the plan cache

2025-03-20 Thread Vladlen Popolitov
Matheus Alcantara писал(а) 2025-03-18 21:56: On Fri, Mar 7, 2025 at 7:43 AM Vladlen Popolitov wrote: > >> Updated patch rebased to the current master. Also I resolved the >> problems >> with the lookup of the compiled expressions. >> Cached jit compiles only e

Re: PoC. The saving of the compiled jit-code in the plan cache

2025-03-07 Thread Vladlen Popolitov
:29:42.995](0.000s) ok 2 - no parameters missing from guc_tables.c [11:29:42.995](0.000s) ok 3 - no parameters marked as NOT_IN_SAMPLE in postgresql.conf.sample found GUC jit_cached in guc_tables.c, missing from postgresql.conf.sample I tested in with make check and make installcheck . In v8 I found bugs, but not published fix yet. -- Best regards, Vladlen Popolitov.

Re: SQL Property Graph Queries (SQL/PGQ)

2025-02-25 Thread Vladlen Popolitov
Ashutosh Bapat писал(а) 2025-02-25 17:20: On Tue, Feb 25, 2025 at 3:17 PM Vladlen Popolitov wrote: Hi! I would ask about CREATE GRAPH PROPERTY. From my point of view it makes very strong check of types including check of typmod. Example: CREATE TABLE userslist ( user_id INT

Re: SQL Property Graph Queries (SQL/PGQ)

2025-02-25 Thread Vladlen Popolitov
ment, but internal dependency), but I have not realised this reason. -- Best regards, Vladlen Popolitov.

Re: Windows meson build

2025-02-13 Thread Vladlen Popolitov
Vladlen Popolitov писал(а) 2025-02-13 17:58: The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: tested, failed Documentation:tested, failed Hi

Re: Windows meson build

2025-02-13 Thread Vladlen Popolitov
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: tested, failed Documentation:tested, failed Hi! This patch clarify the options used by meson to build Po

Re: Better visualization of default values

2025-02-06 Thread Vladlen Popolitov
read that the default value is ... So, what you think about this. It's not complete but you can see if it's useful or not regards Marcos Hi It looks helpful. +1 from me. -- Best regards, Vladlen Popolitov.

Re: Make COPY format extendable: Extract COPY TO format implementations

2025-02-05 Thread Vladlen Popolitov
Álvaro Herrera писал(а) 2025-02-05 18:49: On 2025-Feb-03, Vladlen Popolitov wrote: You use FORMAT option to add new formats, filling it with routine name in shared library. As result any caller can call any routine in PostgreSQL kernel. I think, it will start competition, who can find most

Re: Make COPY format extendable: Extract COPY TO format implementations

2025-02-04 Thread Vladlen Popolitov
Masahiko Sawada писал(а) 2025-02-05 08:32: On Tue, Feb 4, 2025 at 2:46 AM Vladlen Popolitov >> Standard PostgreSQL realisation for new methods to use USING >> keyword. Every >> new method could have own options (FORMAT is option of internal 'copy >> from/to&#

Re: Make COPY format extendable: Extract COPY TO format implementations

2025-02-04 Thread Vladlen Popolitov
Sutou Kouhei писал(а) 2025-02-04 13:29: Hi Hi, In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Mon, 03 Feb 2025 13:38:04 +0700, Vladlen Popolitov wrote: I would like to inform about the security breach in your design of COPY TO/FROM. Thanks

Re: SQL/JSON json_table plan clause

2025-02-02 Thread Vladlen Popolitov
Nikita Malakhov писал(а) 2025-02-03 02:43: Hi hackers! Patch has been rebased onto the current master. -- Regards, Nikita Malakhov Postgres Professional The Russian Postgres Company https://postgrespro.ru/ Hi! Tested on Mac with 'make check', all tests passed OK. -- Best regards

Re: Make COPY format extendable: Extract COPY TO format implementations

2025-02-02 Thread Vladlen Popolitov
SetOptions interface, that defines an options structure according to the new method requirements. I agree with the general direction of the extensibility, but it should be secure and consistent. -- Best regards, Vladlen Popolitov.

Re: EDB Installer initcluster script changes - review requested

2025-01-28 Thread Vladlen Popolitov
in command line. Thanks & Regards Manika Singhal EDB Pune Links: -- [1] https://github.com/EnterpriseDB/edb-installers/issues/98 [2] https://www.postgresql.org/message-id/ca+hukgl5mbn3jquebapbx0yxdntpui04j+ksy2f7kbbhlga...@mail.gmail.com -- Best regards, Vladlen Popolitov.

Re: Increase of maintenance_work_mem limit in 64-bit Windows

2025-01-28 Thread Vladlen Popolitov
" variable maxentries. This variable is the part of other code, I did not touch it, only added explicit cast to long: - maxentries = tbm_calculate_entries(work_mem * 1024L); + maxentries = (long)tbm_calculate_entries(work_mem * (Size)1024); Summary: I did fixes in patch for A,B,C,E comme

Re: Increase of maintenance_work_mem limit in 64-bit Windows

2025-01-28 Thread Vladlen Popolitov
" variable maxentries. This variable is the part of other code, I did not touch it, only added explicit cast to long: - maxentries = tbm_calculate_entries(work_mem * 1024L); + maxentries = (long)tbm_calculate_entries(work_mem * (Size)1024); Summary: I did fixes in patch for A,B,C,E comme

Re: SQL/JSON json_table plan clause

2025-01-16 Thread Vladlen Popolitov
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: not tested Documentation:not tested Hi! Proposed patch tested at Macosx, compiled and build without warni

Re: Windows meson build

2025-01-16 Thread Vladlen Popolitov
make review. -- Best regards, Vladlen Popolitov.

Re: Some ExecSeqScan optimizations

2025-01-10 Thread Vladlen Popolitov
Amit Langote писал(а) 2025-01-10 18:22: On Fri, Jan 10, 2025 at 7:36 PM David Rowley wrote: On Fri, 10 Jan 2025 at 22:53, Vladlen Popolitov wrote: > In case of query > select count(*) from test_table where a_1 = 100; > I would expect increase of query time due to additional

Re: Some ExecSeqScan optimizations

2025-01-10 Thread Vladlen Popolitov
ter, that it is declared as inline. In case of query select count(*) from test_table where a_1 = 100; I would expect increase of query time due to additional if...else . It is not clear what code was eliminated to decrease query time. -- Best regards, Vladlen Popolitov.

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2025-01-09 Thread Vladlen Popolitov
committed again. -- Best regards, Vladlen Popolitov.

Re: Windows meson build

2025-01-09 Thread Vladlen Popolitov
ct location and library version. vcpkg has options for library version and install directory. -- Best regards, Vladlen Popolitov.

Bug and memory leaks with access to file links with long names (Windows, MSVS)

2024-12-27 Thread Vladlen Popolitov
Solution: Proposed patch fixes link information buffer size changing it to the documented value MAXIMUM_REPARSE_DATA_BUFFER_SIZE, and fixes memory leaks - the message buffer copied to a buffer on stack with maximal message size 64Kb. -- Best regards, Vladlen Popol

Re: Windows meson build

2024-12-27 Thread Vladlen Popolitov
Vladlen Popolitov писал(а) 2024-12-27 09:57: Kohei Harikae (Fujitsu) писал(а) 2024-12-27 04:31: Hi, Thank you for your advice. I added a sample setting PKG_CONFIG_PATH based on your advice. How do you think about this? Regards, Kohei Harikae Hi, From my point of view it looks good. Actual

Re: cannot to compile extension by meson on windows

2024-12-27 Thread Vladlen Popolitov
some tests will fail, as they are check log files output and compare it with English answers. I hope this helps you. -- Best regards, Vladlen Popolitov.

Re: Windows meson build

2024-12-26 Thread Vladlen Popolitov
about this variable in meson documentation. -- Best regards, Vladlen Popolitov.

Re: Windows UTF8 system locale

2024-12-25 Thread Vladlen Popolitov
correct UTF-8 symbols - just in case, that they also works. It could be 64 2-bytes UTF-8 characters. It is interesting to look at other opinions. -- Best regards, Vladlen Popolitov.

Re: Windows UTF8 system locale

2024-12-25 Thread Vladlen Popolitov
ontinues to use original long name and fails. It is not clear, what exactly the test checks, if it fails before the dump check. -- Best regards, Vladlen Popolitov.

Re: Windows meson build

2024-12-25 Thread Vladlen Popolitov
"raw" dependency handling for every dependency, they each build in too many variants for that to be a sensible investment of time. Greetings, Andres Freund -- Best regards, Vladlen Popolitov.

Re: COPY performance on Windows

2024-12-25 Thread Vladlen Popolitov
of the input file has the big effect, for many clients their concurrency overhead has big effect. Maybe make the series of the runs with 2 or 4 clients only and compare? -- Best regards, Vladlen Popolitov.

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-12-23 Thread Vladlen Popolitov
Vladlen Popolitov писал(а) 2024-12-23 15:14: Yes, it is also working option. I applied it and tested in the current master under Windows, it works. Attached patch changes this line in meson.build link_with: cflag_libs, + link_whole: cflag_libs, c_pch: pch_c_h, I also

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-12-23 Thread Vladlen Popolitov
Heikki Linnakangas писал(а) 2024-12-23 14:05: On 23/12/2024 12:32, Vladlen Popolitov wrote: I found the reason of this bug and the fix for it. Cool! Fortunatelly meson has option to force put all object files to library - add dependency with the flag link_whole . I made the one-line patch

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-12-23 Thread Vladlen Popolitov
ked install=true and build without any missed files. -- Best regards, Vladlen Popolitov. From 17f3f644ba7564446bb6892eaa8fb4a5d26616f0 Mon Sep 17 00:00:00 2001 From: Vladlen Popolitov Date: Mon, 23 Dec 2024 13:03:48 +0300 Subject: [PATCH v1] Fix meson.build to prevent missed obj file

Re: COPY performance on Windows

2024-12-18 Thread Vladlen Popolitov
lts on all execution orders (17.0 first and 17.0 last)? -- Best regards, Vladlen Popolitov.

Re: COPY performance on Windows

2024-12-17 Thread Vladlen Popolitov
A2376823E2%40TY3PR01MB11891.jpnprd01.prod.outlook.com#8455c9f7b66780a356511f5cfe029d57 OK, I will use it. By the way, do you use prebuild Postgres versions for this test or build it by yourself with the same options? I am going to use built myself. -- Best regards, Vladlen Popolitov.

Re: COPY performance on Windows

2024-12-13 Thread Vladlen Popolitov
you point where is the performance measurement script you mantioned in you email? I will try to play with it. -- Best regards, Vladlen Popolitov.

Re: Add column name to error description

2024-11-06 Thread Vladlen Popolitov
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: not tested Spec compliant: not tested Documentation:not tested Only tests checked. I applied patch (no errors) and did build (no errors

Re: Changing shared_buffers without restart

2024-11-06 Thread Vladlen Popolitov
Hi I tried to apply patches, but failed. I suppose the problem with CRLF in the end of lines in the patch files. At least, after manual change of v1-0001 and v1-0002 from CRLF to LF patches applied, but it was not helped for v1-0003 - v1.0005 - they have also other mistakes during patch process

Re: [PATCH] Add array_reverse() function

2024-10-30 Thread Vladlen Popolitov
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: tested, failed Documentation:tested, failed Content. The proposed function waited long to be implemented

Re: Increase of maintenance_work_mem limit in 64-bit Windows

2024-10-30 Thread Vladlen Popolitov
v.popoli...@postgrespro.ru писал(а) 2024-10-01 00:30: David Rowley писал(а) 2024-09-24 01:07: On Tue, 24 Sept 2024 at 02:47, Vladlen Popolitov wrote: I agree, it is better to fix all them together. I also do not like this hack, it will be removed from the patch, if I check and change all at

Re: Increase of maintenance_work_mem limit in 64-bit Windows

2024-09-24 Thread Vladlen Popolitov
David Rowley писал(а) 2024-09-24 01:07: On Tue, 24 Sept 2024 at 02:47, Vladlen Popolitov wrote: I agree, it is better to fix all them together. I also do not like this hack, it will be removed from the patch, if I check and change all at once. I think, it will take about 1 week to fix and

Re: Increase of maintenance_work_mem limit in 64-bit Windows

2024-09-23 Thread Vladlen Popolitov
David Rowley писал(а) 2024-09-23 15:35: On Mon, 23 Sept 2024 at 21:01, Vladlen Popolitov wrote: Thank you for proposal, I looked at the patch and source code from this point of view. In this approach we need to change all . I counted the appearences of these vars in the code

Re: Increase of maintenance_work_mem limit in 64-bit Windows

2024-09-23 Thread Vladlen Popolitov
rest of the code (only 4 case out of 63 needed to fix for maintenance_work_mem). What do you think about this approach? -- Best regards, Vladlen Popolitov.