Re: Documentation: warn about two_phase when altering a subscription

2024-02-23 Thread Tristen Raab
h their counterpart parameters in the subscription. I feel this makes the description flow a bit better when reading. But other than that I think it's quite clear. kind regards, --- Tristen Raab Highgo Software Canada www.highgo.ca

Re: Add minimal C example and SQL registration example for custom table access methods.

2024-01-26 Thread Tristen Raab
d the documentation builds without any error. The built documentation also looks good with no formatting errors. It's always great to see more examples when reading through documentation so I think this patch is a good addition. thanks, ------- Tristen Raab Highgo Softw

Re: Better help output for pgbench -I init_steps

2023-09-22 Thread Tristen Raab
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Hello, I've reviewed all 4 of your patches, each one applies and builds

Re: Allow specifying a dbname in pg_basebackup connection string

2023-08-28 Thread Tristen Raab
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Hello, I've reviewed your patch and it applies and builds without er

Re: Correct the documentation for work_mem

2023-07-31 Thread Tristen Raab
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, passed Hello, I've reviewed and built the documentation for the updated

Re: pg_waldump: add test for coverage

2023-06-29 Thread Tristen Raab
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Hello, I've reviewed your latest v3 patches on Ubuntu 23.04. Both pa

Re: [PATCH] Allow Postgres to pick an unused port to listen

2023-05-17 Thread Tristen Raab
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, passed Hello Yurii, I've retested your latest patch and tested building