PGSERVICEFILE as part of a normal connection string

2024-11-18 Thread Torsten Förtsch
Hi, I like to bundle all my database connections in a .pg_service.conf. Over time I collected a bunch of such service files. A while back I discovered that the service file can only be specified as an environment variable. It cannot be given as part of the connection string like psql "service=$MY

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-16 Thread Torsten Förtsch
On Tue, Nov 12, 2024 at 3:30 PM Dickson S. Guedes wrote: Are you planning to add changes in docs? Would be important to have > this clarification in there also, IMHO. > Thanks. Here is an updated version of the patch including documentation. From 80e2894d3289cebd9c12d457620bf2965cc0252d Mon Sep

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-12 Thread Torsten Förtsch
Hi Dickson, > > While reviewing your patch for pg_recvlogical, I’m curious about the > expected behavior when using --if-not-exists in conjunction with > --temporary-slot. > > If an existing slot is reused under these options, will it behave as > a temporary slot and be removed when the connection

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-01 Thread Torsten Förtsch
This is another version of the patch. It now includes tests. On Fri, Nov 1, 2024 at 1:42 PM Torsten Förtsch wrote: > On Wed, Oct 30, 2024 at 9:01 AM Peter Eisentraut > wrote: > >> On 27.10.24 13:37, Torsten Förtsch wrote: >> > The attached patch enables pg_recvlogic

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-01 Thread Torsten Förtsch
On Wed, Oct 30, 2024 at 9:01 AM Peter Eisentraut wrote: > On 27.10.24 13:37, Torsten Förtsch wrote: > > The attached patch enables pg_recvlogical to create a temporary slot. > > I think you should explain a bit why you want to do that, what use case > or scenario this is meant

Allowing pg_recvlogical to create temporary replication slots

2024-10-27 Thread Torsten Förtsch
Hi, This is my very first message to this mailing list. Please advise if I am making any mistakes in the procedure. The attached patch enables pg_recvlogical to create a temporary slot. What is the next step in the process to get this change into official postgres? Thanks, Torsten diff --git a/

Re: minor bug

2023-01-19 Thread Torsten Förtsch
If we never expect getRecordTimestamp to fail, then why put it in the if-condition? getRecordTimestamp can fail if the record is not a restore point nor a commit or abort record. A few lines before in the same function there is this: /* Otherwise we only consider stopping before COMMIT or ABORT