Re: Implementing Incremental View Maintenance

2020-02-27 Thread Takuma Hoshiai
ello, > > thank you for patch v14, that fix problems inherited from temporary tables. > it seems that this ASSERT problem with pgss patch is still present ;o( > > Could we have a look ? Sorry but we are busy on fixing and improving IVM patches. I think fixing the assertion failure

Re: Incremental View Maintenance: ERROR: out of shared memory

2020-02-26 Thread Takuma Hoshiai
tables > as pointed out in another thread. So, we are now working on rewrite > our patch not to use temp tables. We fixed this problem in latest patches (v14) in the following thread. https://www.postgresql.org/message-id/20200227150649.101ef342d0e7d7abee320...@sraoss.co.jp

Re: Implementing Incremental View Maintenance

2020-02-26 Thread Takuma Hoshiai
e of these columns also causes IVM fails, so IVM prohibits it too. * Fix incorrect WHERE condition check for outer-join views The check for non null-rejecting condition check was incorrect. Best Regards, Takuma Hoshiai -- Takuma Hoshiai IVM_patches_v14.tar.gz Description: Binary data

Re: Implementing Incremental View Maintenance

2020-02-03 Thread Takuma Hoshiai
+fkw4tv3ce-xufxmsnfpo...@mail.gmail.com Best Regards, Takuma Hoshiai On Mon, 27 Jan 2020 09:19:05 +0900 Takuma Hoshiai wrote: > On Mon, 20 Jan 2020 16:57:58 +0900 > Yugo NAGATA wrote: > > > On Fri, 17 Jan 2020 14:10:32 -0700 (MST) > > legrand legrand wrote: > > > >

Re: Implementing Incremental View Maintenance

2020-01-26 Thread Takuma Hoshiai
of change: > > Thank you for your reporting! We will fix this in the next update. Although I have been working conflict fix and merge latest master, it takes a little longer, because it has large impact than we thought. Please wait a little more. Regards Takuma Hoshiai > Regards

Re: Implementing Incremental View Maintenance

2020-01-13 Thread Takuma Hoshiai
an incremental materialized > view, incorrect results will be obtained when the view is updated after > updating the source table. Thank you for your advice. It's just as you said. LIMIT/OFFSET clause should is prohibited. We will add this to next patch. Best Regards, Takuma Hoshiai >

Re: Implementing Incremental View Maintenance

2019-12-25 Thread Takuma Hoshiai
> > Also, TRUNCATE is not supported. When TRUNCATE command is executed > on a base table, nothing occurs on materialized views. We are > now considering another better options, like: > > - Raise an error or warning when a base table is TRUNCATEed. > - Make the view non-scannable

Re: Implementing Incremental View Maintenance

2019-12-01 Thread Takuma Hoshiai
gt; -- > Tatsuo Ishii > SRA OSS, Inc. Japan > English: http://www.sraoss.co.jp/index_en.php > Japanese:http://www.sraoss.co.jp > Best Regards, -- Takuma Hoshiai IVM_v9.patch.gz Description: Binary data

Re: Implementing Incremental View Maintenance

2019-11-28 Thread Takuma Hoshiai
L, NULL, &Query_for_list_of_matviews}, + {"INCREMENTAL MATERIALIZED VIEW", NULL, NULL, &Query_for_list_of_matviews, THING_NO_DROP | THING_NO_ALTER}, {"INDEX", NULL, NULL, &Query_for_list_of_indexes}, {"LANGUAGE", Query_for_list_of_languages}, {&qu

Re: Proposal to suppress errors thrown by to_reg*()

2019-08-01 Thread Takuma Hoshiai
On Thu, 1 Aug 2019 20:21:57 +1200 Thomas Munro wrote: > On Wed, Jul 31, 2019 at 4:24 AM Tom Lane wrote: > > Takuma Hoshiai writes: > > > [ fix_to_reg_v2.patch ] > > > > I took a quick look through this patch. I'm on board with the goal > > of not havin

Re: Proposal to suppress errors thrown by to_reg*()

2019-07-30 Thread Takuma Hoshiai
On Tue, 30 Jul 2019 12:24:13 -0400 Tom Lane wrote: > Takuma Hoshiai writes: > > [ fix_to_reg_v2.patch ] > > I took a quick look through this patch. I'm on board with the goal > of not having schema-access violations throw an error in these > functions, but the implem

Re: Implementing Incremental View Maintenance

2019-07-09 Thread Takuma Hoshiai
On Wed, 10 Jul 2019 11:07:15 +0900 Takuma Hoshiai wrote: > Hi Thomas, > > 2019年7月8日(月) 15:32 Thomas Munro : > > > On Fri, Jun 28, 2019 at 10:56 PM Yugo Nagata wrote: > > > Attached is a WIP patch of IVM which supports some aggregate functions. > >

Re: Implementing Incremental View Maintenance

2019-07-09 Thread Takuma Hoshiai
post a WIP patch, could you please fix this > small compiler warning? > > describe.c: In function ‘describeOneTableDetails’: > describe.c:3270:55: error: ‘*((void *)&tableinfo+48)’ may be used > uninitialized in this function [-Werror=maybe-uninitialized] > if (verbose && tableinfo.relkind == RELKIND_MATVIEW && tableinfo.isivm) > ^ > describe.c:1495:4: note: ‘*((void *)&tableinfo+48)’ was declared here > } tableinfo; > ^ > It is fixed too. Then our unofficial automatic CI system[1] will run these tests every > day, which sometimes finds problems. > > [1] cfbot.cputube.org > > -- > Thomas Munro > https://enterprisedb.com > > Best regards, Takuma Hoshiai

Re: Proposal to suppress errors thrown by to_reg*()

2019-03-21 Thread Takuma Hoshiai
pesapace ACL error only. so I will use its function. > In the regression test, you are using \gset and \connect psql meta-commands > to test > the user privilege to a namespace, but I think we can make this more simpler > by using SET SESSION AUTHORIZATION and RESET AUTHORIZATION. I forgot this SQL, I fixed to use it. Best regards, -- Takuma Hoshiai fix_to_reg_v2.patch Description: Binary data

Re: Proposal to suppress errors thrown by to_reg*()

2019-03-19 Thread Takuma Hoshiai
is reasonable that we just ignore privileges in the > commands. Maybe regclassin and friends also should be changed in > the same way. Yes, I think so too. But their functions may be used for confirming a obejct visibility, so this time I want to supress errors only. And if want to raise an error about "permission denied for schema xx", would use regclass() function. best regards, -- Takuma Hoshiai > If we protect system catalogs later, the commands naturally will > follow the change. > > regards. > > -- > Kyotaro Horiguchi > NTT Open Source Software Center > >

Proposal to suppress errors thrown by to_reg*()

2019-03-13 Thread Takuma Hoshiai
e current implementation so that they do not throw an error if the name space cannot be accessible by the caller. Attached patch implements this. Comments and suggestions are welcome. -- Takuma Hoshiai fix_to_reg.patch Description: Binary data