On Wed, 20 Nov 2019, Alexey Kondratov wrote:
Hi Steve,
Thank you for review.
I've looked through the patch and tested it.
I don't see any issues with this version. I think it is ready for a
committer.
Regards
--
Alexey Kondratov
Postgres Professional https://www.postgrespro.com
Russi
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, failed
Spec compliant: not tested
Documentation:tested, failed
* I had to replace heap_open/close with table_open/close to get t
On 6/18/19 12:32 AM, Tom Lane wrote:
Steve Singer writes:
The attached patch fixes the issue.
Hmm, that's a pretty obvious mistake :-( but after some fooling around
I've not been able to cause a crash with it. I wonder what test case
you were using, on wha
On 6/15/19 10:18 PM, Tom Lane wrote:
Steve Singer writes:
I encountered the following segfault when running against a PG 12 beta1
during a analyze against a table.
Nobody else has reported this, so you're going to have to work on
producing a self-contained test case, or else debuggi
I encountered the following segfault when running against a PG 12 beta1
during a analyze against a table.
#0 0x56008ad0c826 in update_attstats (vacattrstats=0x0,
natts=2139062143, inh=false,
relid=0x40>) at analyze.c:572
#1 do_analyze_rel (onerel=onerel@entry=0x7f0bc59a7a38,
params
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:tested, passed
I've reviewed the patch and here are my comments.
The feature se
On Thu, 1 Nov 2018, David Rowley wrote:
I ended up going with:
However, this consideration only applies when
is minimal for
non-partitioned tables as all commands must write WAL otherwise.
I've changed this to:
Rows will be frozen only if the table being loaded has been cr
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:tested, failed
--- a/doc/src/sgml/perform.sgml
+++ b/doc/src/sgml/perform.sgml
@
On Mon, 13 Nov 2017, Fabien COELHO wrote:
Hello Steve,
printf("number of transactions actually processed: "
INT64_FORMAT "/%d\n",
- total->cnt - total->skipped, nxacts * nclients);
+ total->cnt, nxacts * nclients);
I think you
