Re: Doc of typmod arg perhaps deserves an update

2024-10-11 Thread Steve Lau
10/11/24 01:33, Steve Lau wrote: >> Before hitting the issue, I thought -1 will be passed if and only if >> this type does not have type modifiers, as it is indeed unknown. However, >> it surprises me that it could also be unknown if your type needs >> type modifiers

Doc of typmod arg perhaps deserves an update

2024-10-10 Thread Steve Lau
# Context I hit the issue described in this thread when building my toy pgvector implementation: https://www.postgresql.org/message-id/162867790903161317q178e11e6ie276d1254c279dd1%40mail.gmail.com, TLDR of the thread is that: When you define a new custom type that needs a type modifier, it is

Re: Unknown annotation '-cim' in source code

2024-07-04 Thread Steve Lau
On Jul 4, 2024, at 4:33 PM, Alvaro Herrera wrote: On 2024-Jul-04, Tom Lane wrote: "David G. Johnston" writes: On Wed, Jul 3, 2024 at 8:46 PM Steve Lau wrote: While reading the source code, I noticed comments like "-cim 9/10/89". It's the initials of the person who

Re: Unknown annotation '-cim' in source code

2024-07-03 Thread Steve Lau
On Jul 4, 2024, at 12:16 PM, David G. Johnston wrote: On Wed, Jul 3, 2024 at 8:46 PM Steve Lau mailto:stevel...@outlook.com>> wrote: While reading the source code, I noticed comments like "-cim 9/10/89". I think this might be an annotation by a developer to indicate the

Unknown annotation '-cim' in source code

2024-07-03 Thread Steve Lau
al context you can provide regarding these annotations. Thank you! Best regards, Steve Lau.