Re: Recovery of .partial WAL segments

2024-10-18 Thread Stefan Fercot
Hi, On Fri, Oct 18, 2024 at 11:07 AM Stepan Neretin wrote: > Hi there! It looks good to me! > Thanks! But I have a question. How is the partialxlogfname freed in case of an > error? I'm not sure I understand your question. What kind of error would you expect exactly? I mostly added a pfree t

Re: Recovery of .partial WAL segments

2024-08-09 Thread Stefan Fercot
Stefan From 203747394503b479338980948ccb3df84dc8d1a1 Mon Sep 17 00:00:00 2001 From: Stefan Fercot Date: Fri, 5 Apr 2024 10:57:03 +0200 Subject: [PATCH v2.] Make XLogFileRead try to restore .partial wal archives Try to restore the normal archived wal segment first and, if not found, then try to restore the archived

Re: Recovery of .partial WAL segments

2024-08-01 Thread Stefan Fercot
k and thoughts about this patch, Kind Regards, -- Stefan FERCOT Data Egret (https://dataegret.com) On Thu, Aug 1, 2024 at 10:23 PM Stefan Fercot wrote: > Dear hackers, > > Generating a ".partial" WAL segment is pretty common nowadays (using > pg_receivewal or during standb

Re: pg_combinebackup fails on file named INCREMENTAL.*

2024-04-16 Thread Stefan Fercot
other, we will only find out how well it works once people will use it on the field and possibly give some feedback. As you mentioned in [1], we're not going to start rewriting the implementation a week after feature freeze nor probably already start building big new things now anywa

Re: Add recovery to pg_control and remove backup_label

2024-04-16 Thread Stefan Fercot
y makes sense to improve the in core backup capabilities, the more we go in that direction, the more we'll rely on outside orchestration. So IMHO it also worth worrying about given more leverage to such orchestration tools. In that sense, I really like the idea to extend the backup functions. Mo

Re: post-freeze damage control

2024-04-16 Thread Stefan Fercot
tion with COW > > filesystems. > > OK. I'll add this as an open item, for me and Robert. Thanks for this! It's probably not up to core docs to state all the steps that would be needed to develop a complete backup solution but documenting the links between the

Re: pg_combinebackup fails on file named INCREMENTAL.*

2024-04-16 Thread Stefan Fercot
ding more info to the backup manifest can be handy for other use-cases too (i.e. like avoiding to store empty files, or storing the checksums state of the cluster). Kind Regards, -- Stefan FERCOT Data Egret (https://dataegret.com)

Re: post-freeze damage control

2024-04-09 Thread Stefan Fercot
get encouraged to do that faster thanks to incremental backups, they could detect potential issues sooner. Ultimately, users will still need their full backups and WAL archives. If pg_combinebackup fails for any reason, the fix will be to perform the recovery from the full backup directly. They still should be able to recover, just slower. -- Stefan FERCOT Data Egret (https://dataegret.com)

Recovery of .partial WAL segments

2024-04-05 Thread Stefan Fercot
_receivewal tests only seem to cover the archives generation but not actually trying to recover using it. I wasn't sure it was interesting to add such tests right now, so I didn't considered it for this patch. Many thanks in advance for your feedback and thoughts about this, Kind Rega

Fwd: Question about xmloption and pg_restore

2018-05-17 Thread Stefan Fercot
estore : /export PGOPTIONS="-c xmloption=DOCUMENT"/. Do you think of any other way to solve this issue ? What if we got the 2 xml options used in the database? Would it be possible to have something like : ALTER TABLE ... ALTER COLUMN ... SET XML OPTION ...; ? Kind regards, -- Stef