Hi Amul,
thanks for working on this.
+ file_name_len = strlen(relpath);
> + if (file_name_len < file_extn_len ||
> + strcmp(relpath + file_name_len - file_extn_len, file_extn) != 0)
> + {
> + if (compress_algorithm == PG_COMPRESSION_NONE)
> + report_backup_error(context,
> + "\"%s\" is not a
I have also done a review of the patch and some testing. The patch looks
good, and I agree with Robert's comments.
On Wed, Jan 17, 2024 at 8:40 PM Robert Haas wrote:
>
> On Wed, Jan 17, 2024 at 6:31 AM Amul Sul wrote:
> > With the attached patch, the backup manifest will have a new key item as
>
Hi,
With the redesign of the archive modules:
35739b87dcfef9fc0186aca659f262746fecd778 - Redesign archive modules
if we were to compile basic_archive module with USE_PGXS=1, we get
compilation error:
[]$ make USE_PGXS=1
gcc -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration
Wed, Dec 7, 2022 at 11:49 AM Kyotaro Horiguchi
wrote:
>
> At Wed, 7 Dec 2022 11:28:23 +0530, Sravan Kumar
> wrote in
> > On Tue, Dec 6, 2022 at 5:24 PM Bharath Rupireddy <
> > bharath.rupireddyforpostg...@gmail.com> wrote:
> >
> > > On Tue, De
On Tue, Dec 6, 2022 at 5:24 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
> On Tue, Dec 6, 2022 at 4:57 PM Sravan Kumar
> wrote:
> >
> > Thank you for the feedback.
> >
> > I'll be glad to help with the fix. Here's the pa
Thank you for the feedback.
I'll be glad to help with the fix. Here's the patch for review.
On Tue, Dec 6, 2022 at 1:54 PM Kyotaro Horiguchi
wrote:
> At Mon, 5 Dec 2022 12:06:11 +0530, Sravan Kumar
> wrote in
> > timeout = PGARCH_AUTOWAKE_INTERVAL - (curtime - last
Hi,
I see that in the archiver code, in the function pgarch_MainLoop,
the archiver sleeps for a certain time or until there's a signal. The time
it sleeps for is represented by:
timeout = PGARCH_AUTOWAKE_INTERVAL - (curtime - last_copy_time);
It so happens that last_copy_time and curtime are alwa
restrict making such mistakes. I had a quick look at the
patch
and the refactoring makes sense.
Thanks,
Sravan Kumar
www.enterprisedb.com
Aside from the stuff that I am complaining about here which is mostly
stylistic, I think that the division of labor between receivelog.c and
walmethods.c is questiona
