Re: Restrict publishing of partitioned table with a foreign table as partition

2025-04-06 Thread Sergey Tatarintsev
_relispartition, BTEqualStrategyNumber, F_BOOLEQ, BoolGetDatum(false)); In this case sch5.part1 is partitioned table, but it also partition of table in different schema -- With best regards, Sergey Tatarintsev, PostgresPro

Re: Restrict publishing of partitioned table with a foreign table as partition

2025-04-03 Thread Sergey Tatarintsev
ds.c @@ -20122,6 +20122,7 @@ ATExecAttachPartition(List **wqueue, Relation rel, PartitionCmd *cmd, relname)));     }     } +   list_free(puboids);     }     /* -- With best regards, Sergey Tatarintsev, PostgresPro

Re: pgbench with partitioned tables

2025-02-11 Thread Sergey Tatarintsev
IND_RELATION is strange and probably unnecessary. Let it be so. I made the suggested changes (patch v4 attached) -- With best regards, Sergey Tatarintsev, PostgresPro From cb363a01cdff72ccde303a1a67180e96bc9e74a8 Mon Sep 17 00:00:00 2001 From: Sergey Tatarintsev Date: Mon, 3 Feb 2025 19:18:0

Re: pgbench with partitioned tables

2025-02-03 Thread Sergey Tatarintsev
03.02.2025 14:57, Álvaro Herrera пишет: On 2025-Feb-03, Sergey Tatarintsev wrote: Thanks for the note. I changed the query in the patch (v2 patch attached) Btw, an additional benefit from the patch is that we can use foreign tables (for example, to test postgres_fdw optimizations) Good

Re: pgbench with partitioned tables

2025-02-02 Thread Sergey Tatarintsev
(v2 patch attached) Btw, an additional benefit from the patch is that we can use foreign tables (for example, to test postgres_fdw optimizations) -- With best regards, Sergey Tatarintsev, PostgresPro From 9aaf2b222d6eb0c218c8a417280a8fdc0a42c296 Mon Sep 17 00:00:00 2001 From: Sergey Tatarintse

pgbench with partitioned tables

2025-01-31 Thread Sergey Tatarintsev
) when generating data for non-regular tables. See attached patch -- With best regards, Sergey Tatarintsev From 9aaf2b222d6eb0c218c8a417280a8fdc0a42c296 Mon Sep 17 00:00:00 2001 From: Sergey Tatarintsev Date: Thu, 30 Jan 2025 14:52:29 +0700 Subject: [PATCH-v1] Fix pgbench client-side data

Re: Restrict publishing of partitioned table with a foreign table as partition

2025-01-30 Thread Sergey Tatarintsev
30.01.2025 19:02, Shlok Kyal пишет: On Wed, 29 Jan 2025 at 19:21, Sergey Tatarintsev wrote: 29.01.2025 12:16, Shlok Kyal пишет: Hi, As part of a discussion in [1], I am starting this thread to address the issue reported for foreign tables. Logical replication of foreign tables is not

Re: Restrict publishing of partitioned table with a foreign table as partition

2025-01-29 Thread Sergey Tatarintsev
CATION pub1 FOR TABLES IN SCHEMA sch3; +CREATE PUBLICATION pub1 FOR ALL TABLES; + +-- Test when a partitioned table with foreign table as a partition is attached +-- to partitioned table which is already published +ALTER TABLE sch3.tmain DETACH PARTITION sch3.part2; +CREATE PUBLICATION pub1 FOR TABLE sch3.

Re: create subscription with (origin = none, copy_data = on)

2025-01-28 Thread Sergey Tatarintsev
23.01.2025 09:46, Amit Kapila пишет: On Wed, Jan 22, 2025 at 9:44 PM Sergey Tatarintsev wrote: 22.01.2025 18:41, Shlok Kyal пишет: Also we still don't care about foreign partitions (as I wrote earlier we should raise an ERROR for such publications). I think dealing with this separ

CREATE PUBLICATION and foreign partitions

2025-01-28 Thread Sergey Tatarintsev
ql.org/docs/devel/logical-replication-restrictions.html From c69e26ef8519dfbfee9edf586ec8742f79e92269 Mon Sep 17 00:00:00 2001 From: Sergey Tatarintsev Date: Wed, 29 Jan 2025 12:40:54 +0700 Subject: [PATCH] Attempts to replicate partitioned tables with foreign partitions, will result in a

Re: create subscription with (origin = none, copy_data = on)

2025-01-24 Thread Sergey Tatarintsev
24.01.2025 07:22, Shlok Kyal пишет: On Thu, 23 Jan 2025 at 17:54, Zhijie Hou (Fujitsu) wrote: On Thursday, January 23, 2025 4:43 PM Shlok Kyal wrote: On Thu, 23 Jan 2025 at 12:35, Shlok Kyal wrote: On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) wrote: Thanks for the patch. I agree

Re: create subscription with (origin = none, copy_data = on)

2025-01-23 Thread Sergey Tatarintsev
23.01.2025 15:24, Zhijie Hou (Fujitsu) пишет: On Thursday, January 23, 2025 4:43 PM Shlok Kyal wrote: On Thu, 23 Jan 2025 at 12:35, Shlok Kyal wrote: On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) wrote: Thanks for the patch. I agree that covering the partitioned table case when che

Re: create subscription with (origin = none, copy_data = on)

2025-01-22 Thread Sergey Tatarintsev
22.01.2025 18:41, Shlok Kyal пишет: On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) wrote: On Tuesday, January 21, 2025 1:31 AM vignesh C wrote: Hi, On Mon, 20 Jan 2025 at 17:31, Amit Kapila wrote: On Sat, Jan 18, 2025 at 10:31 AM vignesh C wrote: Attached patch has the fix for thi

Re: create subscription with (origin = none, copy_data = on)

2025-01-18 Thread Sergey Tatarintsev
18.01.2025 12:01, vignesh C пишет: On Fri, 17 Jan 2025 at 21:30, vignesh C wrote: On Fri, 17 Jan 2025 at 14:00, Sergey Tatarintsev wrote: Hi, hackers! I am looking at subscription creation command: CREATE SUBSCRIPTION sub CONNECTION '...' PUBLICATION pub WITH (origin = none, copy

Re: create subscription with (origin = none, copy_data = on)

2025-01-17 Thread Sergey Tatarintsev
17.01.2025 23:00, vignesh C пишет: On Fri, 17 Jan 2025 at 14:00, Sergey Tatarintsev wrote: Hi, hackers! I am looking at subscription creation command: CREATE SUBSCRIPTION sub CONNECTION '...' PUBLICATION pub WITH (origin = none, copy_data = on); For now we log a warning if the

create subscription with (origin = none, copy_data = on)

2025-01-17 Thread Sergey Tatarintsev
Hi, hackers! I am looking at subscription creation command: CREATE SUBSCRIPTION sub CONNECTION '...' PUBLICATION pub WITH (origin = none, copy_data = on); For now we log a warning if the publisher has subscribed to the same table from some other publisher. However, in case of publication wit