Re:Detach shared memory in Postmaster child if not needed

2024-07-29 Thread Rui Zhao
ird-party code in existence to > break but you should change to comment. Thank you for your reminder. My v2 patch will include the comments for postmaster_child_launch(). -- Best regards, Rui Zhao 0001-Detach-shared-memory-in-Postmaster-child-if-not-needed-v2.patch Description: Binary data

Detach shared memory in Postmaster child if not needed

2024-07-29 Thread Rui Zhao
e any risk of accidentally corrupting shared memory. Additionally, any panic in these processes will not reset shared memory. The attached patch addresses this issue by detaching shared memory after fork_process(). Best regard, Rui Zhao 0001-Detach-shared-memory-in-Postmaster-child-if-not-needed.

Re: pg_upgrade fails with in-place tablespace[

2023-09-04 Thread Rui Zhao
' requirements. It would be highly appreciated if the official PG could also incorporate support for this feature. -- Best regards, Rui Zhao

Re: pg_upgrade fails with in-place tablespace

2023-09-04 Thread Rui Zhao
' requirements. It would be highly appreciated if the official PG could also incorporate support for this feature. -- Best regards, Rui Zhao -- From:Michael Paquier Sent At:2023 Sep. 1 (Fri.) 12:58 To:Mark Cc:pgsql-hackers Subje

Re: pg_upgrade fails with in-place tablespace

2023-08-26 Thread Rui Zhao
Could you please provide more thoughts about this issue? pg_upgrade is the final issue of in-place tablespace and we are on the cusp of success. -- Best regards, Rui Zhao

Re: pg_upgrade fails with in-place tablespace

2023-08-19 Thread Rui Zhao
we can take it a step further by providing an option that allows the check to pass if the caller explicitly adds --old-options="-c allow_in_place_tablespaces=on". Please refer to the TAP test I have included for a better understanding of my suggestion. -- Best regards, Rui Zhao

Re: pg_upgrade fails with in-place tablespace

2023-08-18 Thread Rui Zhao
Please review my latest patch. -- Best regards, Rui Zhao 0001-Fix-pg_upgrade-with-in-place-tablespaces.patch Description: Binary data

Re: pg_upgrade fails with in-place tablespace

2023-08-08 Thread Rui Zhao
it. I will try to respond to pg_upgrade after my deep dive. -- Best regards, Rui Zhao

Re: pg_upgrade fails with in-place tablespace

2023-08-07 Thread Rui Zhao
ing a binary upgrade. Please review my lastest patch. -- Best regards, Rui Zhao 0001-Fix-pg_upgrade-with-in-place-tablespaces.patch Description: Binary data

Re: pg_upgrade fails with in-place tablespace

2023-08-02 Thread Rui Zhao
essary modifications to ensure compatibility with in-place tablespaces. Please find the updated code attached. -- Best regards, Rui Zhao -- From:Michael Paquier Sent At:2023 Aug. 1 (Tue.) 08:57 To:Mark Cc:pgsql-hackers Subject:Re: pg_upgrad

回复:pg_rewind fails with in-place tablespace

2023-07-31 Thread Rui Zhao
the final issue. Thank you for your understanding and assistance. Best regard, Rui Zhao -- 发件人:Michael Paquier 发送时间:2023年7月31日(星期一) 06:49 收件人:赵锐(惜元) 抄 送:pgsql-hackers ; Thomas Munro 主 题:Re: pg_rewind fails with in-place tablespace O

pg_upgrade fails with in-place tablespace

2023-07-31 Thread Rui Zhao
My solution may be more lightweight and harmless. Thank you for your attention to this matter. Best regards, Rui Zhao 0001-Fix-pg_upgrade-fails-with-in-place-tablespace.patch Description: Binary data

Re:Possible corruption by CreateRestartPoint at promotion

2022-04-26 Thread Rui Zhao
Kyotaro's patch seems good to me and fixes the test case in my patch. Do you have interest in adding a test like one in my patch? > + LWLockAcquire(ControlFileLock, LW_EXCLUSIVE); > + > /* > * Remember the prior checkpoint's redo ptr for > * UpdateCheckPointDistanceEstimate(